[JBPM-10072] EJBTimerScheduler.getTimerByName inefficient with large number of timers #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elguardian
force-pushed
the
JBPM-10072
branch
3 times, most recently
from
fd55625
to
fa15415
Compare
|
jenkins do fdb |
gmunozfe
suggested changes
May 9, 2022
jbpm-db-scripts/src/main/resources/db/upgrade-scripts/db2/rhpam-7.13-to-7.14.sql
Outdated
Show resolved
Hide resolved
| @@ -16,10 +16,19 @@ | |||
|
|
|||
| package org.jbpm.services.ejb.timer; | |||
|
|
|||
| import java.io.ByteArrayInputStream; | |||
| import java.io.IOException; | |||
| @@ -49,6 +50,9 @@ public class TimerMappingInfo implements Serializable { | |||
| @Column(nullable = false) | |||
| private String uuid; | |||
|
|
|||
| @Lob | |||
...ejb/jbpm-services-ejb-timer/src/main/java/org/jbpm/services/ejb/timer/EJBTimerScheduler.java
Outdated
Show resolved
Hide resolved
| @@ -54,6 +54,7 @@ public void setup() { | |||
| timers.add(timer1); | |||
|
|
|||
| scheduler = new EJBTimerScheduler(); | |||
| scheduler.setUseLocalCache(true); | |||
There was a problem hiding this comment.
cache was causing a memory leak and it is not needed anymore.
|
jenkins do fdb |
|
SonarCloud Quality Gate failed. |
gmunozfe
approved these changes
May 11, 2022
elguardian
added a commit
to elguardian/jbpm
that referenced
this pull request
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/JBPM-10072