Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-10087] Timer not deleted at process instance abort #2154

Merged
merged 1 commit into from Jun 27, 2022
Merged

[JBPM-10087] Timer not deleted at process instance abort #2154

merged 1 commit into from Jun 27, 2022

Conversation

elguardian
Copy link
Member

gmunozfe
gmunozfe reviewed Jun 6, 2022
View reviewed changes
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, still reviewing it as I wasn't able to reproduce the issue

...b/jbpm-services-ejb-timer/src/main/java/org/jbpm/services/ejb/timer/EjbSchedulerService.java Outdated Show resolved Hide resolved
jbpm-test-coverage/src/test/java/org/jbpm/test/functional/timer/GlobalTimerServiceBaseTest.java Outdated Show resolved Hide resolved
jbpm-runtime-manager/src/main/java/org/jbpm/runtime/manager/impl/AbstractRuntimeManager.java Outdated Show resolved Hide resolved
@elguardian elguardian force-pushed the JBPM-10087 branch 2 times, most recently from d63189e to aeb5498 Compare June 7, 2022 09:52
@elguardian
Copy link
Member Author

Jenkins retest this please

@elguardian elguardian force-pushed the JBPM-10087 branch 5 times, most recently from ed726ef to a526dab Compare June 21, 2022 08:59
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

55.8% 55.8% Coverage
2.9% 2.9% Duplication

@elguardian elguardian merged commit 692b6fc into kiegroup:main Jun 27, 2022
@elguardian elguardian deleted the JBPM-10087 branch June 27, 2022 06:31
@afalhambra afalhambra mentioned this pull request Jul 21, 2022
Merged
afalhambra pushed a commit to afalhambra/jbpm that referenced this pull request Jul 21, 2022
@elguardian @afalhambra
[JBPM-10087] Timer not deleted at process instance abort (kiegroup#2154)
ea8cde2
afalhambra pushed a commit to afalhambra/jbpm that referenced this pull request Jul 21, 2022
@elguardian @afalhambra
[JBPM-10087] Timer not deleted at process instance abort (kiegroup#2154)
283a0af
elguardian added a commit that referenced this pull request Aug 5, 2022
@afalhambra @elguardian
[JBPM-10087] Timer not deleted at process instance abort (#2154) (#2170)
d4b0c9a 
Co-authored-by: Enrique González Martínez <egonzale@redhat.com>
elguardian added a commit that referenced this pull request Aug 5, 2022
@afalhambra @elguardian
[JBPM-10087] Timer not deleted at process instance abort (#2154) (#2169)
d7a84bc 
Co-authored-by: Enrique González Martínez <egonzale@redhat.com>
fjtirado pushed a commit to fjtirado/jbpm that referenced this pull request Oct 5, 2022
@afalhambra @elguardian @fjtirado
[JBPM-10087] Timer not deleted at process instance abort (kiegroup#2154…
802c8ff 
…) (kiegroup#2170)

Co-authored-by: Enrique González Martínez <egonzale@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmunozfe gmunozfe gmunozfe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@elguardian @gmunozfe