[RHPAM-4445] Unable to update the task description with long string(m… #2201
Conversation
…ore than 255 chars)
|
Can one of the admins verify this patch? |
11 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
| String message = getUpdateFieldLog("Description", auditTaskImpl.getDescription(), ti.getDescription()); | ||
|
|
||
| if (message != null && message.length() > TASK_DESCRIPTION_LENGTH) { |
There was a problem hiding this comment.
this should not be required. it should be trimmed already in the task.
There was a problem hiding this comment.
Hi @elguardian, TaskEvent message is getting persisted in the TaskEvent table and here task event message build as "Updated Description from: 'old value' to:new value' ". If new value of task description is 255 chars, overall task event message length is more than 255 chars so we have to trim the message as well.
There was a problem hiding this comment.
that is the reason it should be done in some other place. you will have a description that won't match database.
There was a problem hiding this comment.
@elguardian I agree task description in TaskEvent wont match with task description in other tables, but message field from TaskEvent is not used anywhere else and actual value of TaskDescription is captured and in sync in Task and AuditTaskImpl table. If we dont update the TaskEvent.message then we have to trim the taskDescription more than defined length. I can modify warn message and capture the task event message before truncating.
There was a problem hiding this comment.
@abhijithumbe task event is used in emitters... anycase there is much time for the cut off. I will let this slip
There was a problem hiding this comment.
Hi @abhijithumbe, can you please elaborate a little more in the jira ticket. Seeing the PR is not clear to me about the scope, since the DDL scripts are fixed and limiting the length of this field to 255 chars. So even if customer set this new property to a value higher than 255, it will keep on failing if the description is longer than 255 characters.
| private static final Logger logger = LoggerFactory.getLogger(TaskImpl.class); | ||
|
|
||
| @Transient | ||
| private final int TASK_DESCRIPTION_LENGTH = Integer.parseInt(System.getProperty("org.jbpm.ht.task.description.length", "255")); |
There was a problem hiding this comment.
| private final int TASK_DESCRIPTION_LENGTH = Integer.parseInt(System.getProperty("org.jbpm.ht.task.description.length", "255")); | |
| private static final int TASK_DESCRIPTION_LENGTH = Integer.parseInt(System.getProperty("org.jbpm.ht.task.description.length", "255")); |
There was a problem hiding this comment.
Hi @afalhambra Values defined for system-property and DB column size should be in sync. We need to use Alter table query to modify DB column size based on value defined for system-property
| @@ -63,6 +63,8 @@ public class JPATaskLifeCycleEventListener extends PersistableEventListener impl | |||
| private static final Logger logger = LoggerFactory.getLogger(JPATaskLifeCycleEventListener.class); | |||
| private List<ArchiveLoggerProvider> archiveLoggerProviders; | |||
|
|
|||
| private final int TASK_DESCRIPTION_LENGTH = Integer.parseInt(System.getProperty("org.jbpm.ht.task.description.length", "255")); | |||
There was a problem hiding this comment.
| private final int TASK_DESCRIPTION_LENGTH = Integer.parseInt(System.getProperty("org.jbpm.ht.task.description.length", "255")); | |
| private static final int TASK_DESCRIPTION_LENGTH = Integer.parseInt(System.getProperty("org.jbpm.ht.task.description.length", "255")); |
…ore than 255 chars)
abhijithumbe
requested review from
afalhambra and
elguardian
and removed request for
afalhambra and
elguardian
|
Jenkins retest this please |
|
Kudos, SonarCloud Quality Gate passed! |
|
@abhijithumbe plz backport this to7.67 and 7.67-blue |
|
Thanks @elguardian . Opened PR for #2207 and #2208 for 7.67 and 7.67-blue branch. |
…ore than 255 chars)
JIRA: (https://issues.redhat.com/browse/JBPM-10113)