Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBPM-10142- Review JPA mapper for consistently close entity manager … #2239

Merged
merged 1 commit into from Dec 2, 2022
Merged

JBPM-10142- Review JPA mapper for consistently close entity manager … #2239

merged 1 commit into from Dec 2, 2022

Conversation

cristianonicolai
Copy link
Contributor

…usign finally block

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

gmunozfe
gmunozfe approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, well done @cristianonicolai !

@fjtirado fjtirado changed the title RHPAM-4583 - Review JPA mapper for consistently close entity manager … JBPM-10142- Review JPA mapper for consistently close entity manager … Dec 1, 2022
@cristianonicolai cristianonicolai merged commit 5ed15d8 into kiegroup:main Dec 2, 2022
@cristianonicolai cristianonicolai deleted the RHPAM-4583 branch December 2, 2022 01:35
cristianonicolai added a commit to cristianonicolai/jbpm that referenced this pull request Dec 2, 2022
@cristianonicolai
RHPAM-4583 - Review JPA mapper for consistently close entity manager …
ed171b4 
…usign finally block (kiegroup#2239)
cristianonicolai added a commit to cristianonicolai/jbpm that referenced this pull request Dec 2, 2022
@cristianonicolai
RHPAM-4583 - Review JPA mapper for consistently close entity manager …
8baa1ae 
…usign finally block (kiegroup#2239)
cristianonicolai added a commit that referenced this pull request Dec 5, 2022
@cristianonicolai @fjtirado
[7.67.x-blue] JBPM-10142 Closing entity manager when an exception is …
f3c3bef 
…thrown (#2242)

* RHPAM-4583 - Review JPA mapper for consistently close entity manager usign finally block (#2239)

* [JBPM-10142] Improving clean up (#2238)

Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
cristianonicolai added a commit that referenced this pull request Dec 5, 2022
@cristianonicolai @fjtirado
[7.67.x] JBPM-10142 Closing entity manager when an exception is thrown (
c94b01c 
#2241)

* RHPAM-4583 - Review JPA mapper for consistently close entity manager usign finally block (#2239)

* [JBPM-10142] Improving clean up (#2238)

Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmunozfe gmunozfe gmunozfe approved these changes

@fjtirado fjtirado fjtirado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cristianonicolai @gmunozfe @fjtirado