Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-10087] Trying to create new transaction to perform query #2274

Merged
merged 1 commit into from Mar 16, 2023

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Mar 8, 2023

Customer reported a failure on timer involved scenarios.
Log contains this exception

Caused by: org.hibernate.exception.GenericJDBCException: could not prepare statement
	at deployment.ROOT.war//org.hibernate.exception.internal.StandardSQLExceptionConverter.convert(StandardSQLExceptionConverter.java:47)
	at deployment.ROOT.war//org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:113)
	at deployment.ROOT.war//org.hibernate.engine.jdbc.internal.StatementPreparerImpl$StatementPreparationTemplate.prepareStatement(StatementPreparerImpl.java:186)
	at deployment.ROOT.war//org.hibernate.engine.jdbc.internal.StatementPreparerImpl.prepareQueryStatement(StatementPreparerImpl.java:151)
	at deployment.ROOT.war//org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:2082)
	at deployment.ROOT.war//org.hibernate.loader.Loader.executeQueryStatement(Loader.java:2012)
	at deployment.ROOT.war//org.hibernate.loader.Loader.executeQueryStatement(Loader.java:1990)
	at deployment.ROOT.war//org.hibernate.loader.Loader.doQuery(Loader.java:949)
	at deployment.ROOT.war//org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:351)
	at deployment.ROOT.war//org.hibernate.loader.Loader.doList(Loader.java:2787)
	at deployment.ROOT.war//org.hibernate.loader.Loader.doList(Loader.java:2770)
	at deployment.ROOT.war//org.hibernate.loader.Loader.listIgnoreQueryCache(Loader.java:2604)
	at deployment.ROOT.war//org.hibernate.loader.Loader.list(Loader.java:2599)
	at deployment.ROOT.war//org.hibernate.loader.hql.QueryLoader.list(QueryLoader.java:505)
	at deployment.ROOT.war//org.hibernate.hql.internal.ast.QueryTranslatorImpl.list(QueryTranslatorImpl.java:395)
	at deployment.ROOT.war//org.hibernate.engine.query.spi.HQLQueryPlan.performList(HQLQueryPlan.java:220)
	at deployment.ROOT.war//org.hibernate.internal.SessionImpl.list(SessionImpl.java:1526)
	at deployment.ROOT.war//org.hibernate.query.internal.AbstractProducedQuery.doList(AbstractProducedQuery.java:1598)
	at deployment.ROOT.war//org.hibernate.query.internal.AbstractProducedQuery.list(AbstractProducedQuery.java:1566)
	... 42 more
Caused by: java.sql.SQLException: IJ031070: Transaction cannot proceed: STATUS_ROLLEDBACK
	at org.jboss.ironjacamar.jdbcadapters@1.5.3.SP2-redhat-00001//org.jboss.jca.adapters.jdbc.WrapperDataSource.checkTransactionActive(WrapperDataSource.java:272)
	at org.jboss.ironjacamar.jdbcadapters@1.5.3.SP2-redhat-00001//org.jboss.jca.adapters.jdbc.WrappedConnection.checkTransactionActive(WrappedConnection.java:2005)
	at org.jboss.ironjacamar.jdbcadapters@1.5.3.SP2-redhat-00001//org.jboss.jca.adapters.jdbc.WrappedConnection.checkStatus(WrappedConnection.java:2020)
	at org.jboss.ironjacamar.jdbcadapters@1.5.3.SP2-redhat-00001//org.jboss.jca.adapters.jdbc.WrappedConnection.checkTransaction(WrappedConnection.java:1994)
	at org.jboss.ironjacamar.jdbcadapters@1.5.3.SP2-redhat-00001//org.jboss.jca.adapters.jdbc.WrappedConnection.prepareStatement(WrappedConnection.java:472)
	at deployment.ROOT.war//org.hibernate.engine.jdbc.internal.StatementPreparerImpl$5.doPrepare(StatementPreparerImpl.java:149)
	at deployment.ROOT.war//org.hibernate.engine.jdbc.internal.StatementPreparerImpl$StatementPreparationTemplate.prepareStatement(StatementPreparerImpl.java:176)

Trying to execute query https://github.com/kiegroup/jbpm/blob/main/jbpm-services/jbpm-services-ejb/jbpm-services-ejb-timer/src/main/java/org/jbpm/services/ejb/timer/EjbSchedulerService.java#L162 within a new transaction if the current one is rolled back

@fjtirado fjtirado marked this pull request as draft March 8, 2023 16:23
@fjtirado fjtirado requested a review from gmunozfe March 8, 2023 16:27
@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@fjtirado fjtirado marked this pull request as ready for review March 9, 2023 15:56
@fjtirado fjtirado added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Mar 9, 2023
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's see how it works with the reproducer. Just one comment for adding other invalid transaction status.

@fjtirado fjtirado merged commit 454fe3d into kiegroup:main Mar 16, 2023
8 of 10 checks passed
fjtirado added a commit that referenced this pull request Mar 22, 2023
#2275)

Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
fjtirado added a commit that referenced this pull request Mar 22, 2023
#2276)

Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
2 participants