Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-10174] Do not call readValue in VariableScope #2288

Merged
merged 4 commits into from Jun 6, 2023
Merged

[JBPM-10174] Do not call readValue in VariableScope #2288

merged 4 commits into from Jun 6, 2023

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Jun 1, 2023 •
edited

JIRA:

link

@fjtirado fjtirado marked this pull request as ready for review June 1, 2023 11:20
VaniHaripriya
VaniHaripriya approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@VaniHaripriya VaniHaripriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fjtirado , Looks good to me.

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@fjtirado fjtirado force-pushed the JBPM-10174 branch 6 times, most recently from 268bc2a to e24f221 Compare June 5, 2023 10:04
gmunozfe
gmunozfe approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, outstanding work @fjtirado!
Just remember to add "cherry-pick" labels

@fjtirado fjtirado added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Jun 5, 2023
@fjtirado fjtirado force-pushed the JBPM-10174 branch 3 times, most recently from 230fee9 to 0654837 Compare June 6, 2023 09:27
@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.5% 95.5% Coverage
0.0% 0.0% Duplication

@fjtirado fjtirado merged commit 53313be into kiegroup:main Jun 6, 2023
5 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 6, 2023
@fjtirado @web-flow
[JBPM-10174] Do not call readValue in VariableScope (#2288)
0bd3dcb 
* [JBPM-10174] Do not call readValue in VariableScope

* [JBPM-10174] Sonar warnings

* [JBPM-10174] Supporting date conversion

* [JBPM-10174] Increasing coverage
github-actions bot pushed a commit that referenced this pull request Jun 6, 2023
@fjtirado @web-flow
[JBPM-10174] Do not call readValue in VariableScope (#2288)
375a89b 
* [JBPM-10174] Do not call readValue in VariableScope

* [JBPM-10174] Sonar warnings

* [JBPM-10174] Supporting date conversion

* [JBPM-10174] Increasing coverage
This was referenced Jun 6, 2023
Merged
Merged
fjtirado added a commit that referenced this pull request Jun 7, 2023
@github-actions @fjtirado
[JBPM-10174] Do not call readValue in VariableScope (#2288) (#2294)
f620f6a 
* [JBPM-10174] Do not call readValue in VariableScope

* [JBPM-10174] Sonar warnings

* [JBPM-10174] Supporting date conversion

* [JBPM-10174] Increasing coverage

Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
fjtirado added a commit that referenced this pull request Jun 7, 2023
@github-actions @fjtirado
[JBPM-10174] Do not call readValue in VariableScope (#2288) (#2293)
cd6f12f 
* [JBPM-10174] Do not call readValue in VariableScope

* [JBPM-10174] Sonar warnings

* [JBPM-10174] Supporting date conversion

* [JBPM-10174] Increasing coverage

Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
fjtirado added a commit to fjtirado/jbpm that referenced this pull request Aug 17, 2023
@fjtirado
[JBPM-10174] Do not call readValue in VariableScope (kiegroup#2288)
2cd9991 
* [JBPM-10174] Do not call readValue in VariableScope

* [JBPM-10174] Sonar warnings

* [JBPM-10174] Supporting date conversion

* [JBPM-10174] Increasing coverage
fjtirado added a commit to fjtirado/jbpm that referenced this pull request Sep 15, 2023
@fjtirado
[JBPM-10174] Do not call readValue in VariableScope (kiegroup#2288)
6c6e409 
* [JBPM-10174] Do not call readValue in VariableScope

* [JBPM-10174] Sonar warnings

* [JBPM-10174] Supporting date conversion

* [JBPM-10174] Increasing coverage
fjtirado added a commit to fjtirado/jbpm that referenced this pull request Sep 15, 2023
@fjtirado
[JBPM-10174] Do not call readValue in VariableScope (kiegroup#2288)
baaf7f9 
* [JBPM-10174] Do not call readValue in VariableScope

* [JBPM-10174] Sonar warnings

* [JBPM-10174] Supporting date conversion

* [JBPM-10174] Increasing coverage
fjtirado added a commit to fjtirado/jbpm that referenced this pull request Nov 7, 2023
@fjtirado
[JBPM-10174] Do not call readValue in VariableScope (kiegroup#2288)
822544b 
* [JBPM-10174] Do not call readValue in VariableScope

* [JBPM-10174] Sonar warnings

* [JBPM-10174] Supporting date conversion

* [JBPM-10174] Increasing coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmunozfe gmunozfe gmunozfe approved these changes

@VaniHaripriya VaniHaripriya VaniHaripriya approved these changes

Assignees
No one assigned
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Milestone
No milestone
3 participants
@fjtirado @gmunozfe @VaniHaripriya