Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kie-issues-386] PIM removes dynamic task description of Human Tasks #2301

Merged
merged 2 commits into from Aug 1, 2023

Conversation

elguardian
Copy link
Member

@elguardian
Copy link
Member Author

failures not related

@elguardian
Copy link
Member Author

Jenkins retest this please

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@martinweiler martinweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @elguardian

@martinweiler martinweiler changed the title [kie-issues-386] Test case to verify dynamic task description during process migration / fix [kie-issues-386] PIM removes dynamic task description of Human Tasks Jul 24, 2023
Copy link
Member

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -92,6 +92,9 @@ public Map<String, String> getInMappings() {
}

public void addInAssociation(DataAssociation dataAssociation) {
if (dataAssociation.getTarget().equals("Description")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we want to do the replacement for any other property different than description?

@fjtirado fjtirado added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Aug 1, 2023
@fjtirado fjtirado merged commit 31944ae into kiegroup:main Aug 1, 2023
9 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
…2301)

* [kie-issues-386] Test case to verify dynamic task description during process migration

* [kie-issues-386] Test case to verify dynamic task description during process migration / fix

---------

Co-authored-by: Martin Weiler <mweiler@redhat.com>
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
…2301)

* [kie-issues-386] Test case to verify dynamic task description during process migration

* [kie-issues-386] Test case to verify dynamic task description during process migration / fix

---------

Co-authored-by: Martin Weiler <mweiler@redhat.com>
fjtirado pushed a commit that referenced this pull request Aug 2, 2023
…2301) (#2311)

* [kie-issues-386] Test case to verify dynamic task description during process migration

* [kie-issues-386] Test case to verify dynamic task description during process migration / fix

---------

Co-authored-by: Enrique <egonzale@redhat.com>
Co-authored-by: Martin Weiler <mweiler@redhat.com>
fjtirado pushed a commit that referenced this pull request Aug 2, 2023
…2301) (#2310)

* [kie-issues-386] Test case to verify dynamic task description during process migration

* [kie-issues-386] Test case to verify dynamic task description during process migration / fix

---------

Co-authored-by: Enrique <egonzale@redhat.com>
Co-authored-by: Martin Weiler <mweiler@redhat.com>
@elguardian elguardian deleted the kie-issues-386 branch August 3, 2023 06:58
fjtirado pushed a commit to fjtirado/jbpm that referenced this pull request Aug 17, 2023
…iegroup#2301)

* [kie-issues-386] Test case to verify dynamic task description during process migration

* [kie-issues-386] Test case to verify dynamic task description during process migration / fix

---------

Co-authored-by: Martin Weiler <mweiler@redhat.com>
fjtirado pushed a commit to fjtirado/jbpm that referenced this pull request Sep 15, 2023
…iegroup#2301)

* [kie-issues-386] Test case to verify dynamic task description during process migration

* [kie-issues-386] Test case to verify dynamic task description during process migration / fix

---------

Co-authored-by: Martin Weiler <mweiler@redhat.com>
fjtirado pushed a commit to fjtirado/jbpm that referenced this pull request Sep 15, 2023
…iegroup#2301)

* [kie-issues-386] Test case to verify dynamic task description during process migration

* [kie-issues-386] Test case to verify dynamic task description during process migration / fix

---------

Co-authored-by: Martin Weiler <mweiler@redhat.com>
fjtirado pushed a commit to fjtirado/jbpm that referenced this pull request Nov 7, 2023
…iegroup#2301)

* [kie-issues-386] Test case to verify dynamic task description during process migration

* [kie-issues-386] Test case to verify dynamic task description during process migration / fix

---------

Co-authored-by: Martin Weiler <mweiler@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
4 participants