Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[private-bamoe-issues#1326] Avoid duplicate timer execution with long running timers and async nodes #2373

Merged
merged 2 commits into from Jan 8, 2024

Conversation

martinweiler
Copy link
Contributor

JIRA: https://issues.redhat.com/browse/RHPAM-4864

Add equals/hashCode methods in order to ensure List.contains works properly.

@fjtirado fjtirado added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Dec 11, 2023
Copy link
Contributor

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions.
Great work @martinweiler

Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though @fjtirado suggestions seem fine to be considered

Copy link

sonarcloud bot commented Jan 3, 2024

@fjtirado fjtirado merged commit f6a3692 into kiegroup:main Jan 8, 2024
2 of 4 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 8, 2024
… running timers and async nodes (#2373)

* [private-bamoe-issues#1326] Avoid duplicate timer execution with long running timers and async nodes

* [private-bamoe-issues#1326] Simplify the equals/hashCode methods
github-actions bot pushed a commit that referenced this pull request Jan 8, 2024
… running timers and async nodes (#2373)

* [private-bamoe-issues#1326] Avoid duplicate timer execution with long running timers and async nodes

* [private-bamoe-issues#1326] Simplify the equals/hashCode methods
mareknovotny pushed a commit that referenced this pull request Jan 18, 2024
… running timers and async nodes (#2373) (#2376)

* [private-bamoe-issues#1326] Avoid duplicate timer execution with long running timers and async nodes

* [private-bamoe-issues#1326] Simplify the equals/hashCode methods

Co-authored-by: Martin Weiler <mweiler@redhat.com>
mareknovotny pushed a commit that referenced this pull request Jan 22, 2024
… running timers and async nodes (#2373) (#2375)

* [private-bamoe-issues#1326] Avoid duplicate timer execution with long running timers and async nodes

* [private-bamoe-issues#1326] Simplify the equals/hashCode methods

Co-authored-by: Martin Weiler <mweiler@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
4 participants