Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-6066] Allow usage of configuration entries in creation of MarshallingStrategies #866

Closed
wants to merge 1 commit into from

Conversation

ngs-mtech
Copy link
Contributor

We are using complex deployment descriptors full of configuration entries, but we are not able to use them in creation of object marshalling strategies. With this small change we can define a configuration entry named project_persistence_unit and use it in the calling to the creation of our custom marshalling strategy.

@kie-ci
Copy link

kie-ci commented Jun 5, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

3 similar comments
@kie-ci
Copy link

kie-ci commented Jun 5, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jun 5, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jun 5, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@tsurdilo
Copy link
Member

tsurdilo commented Jun 5, 2017

ok to test

@mswiderski
Copy link
Contributor

@ngs-mtech could you please create jira and describe the problem/improvment need?

Looks like you have bunch of commits that should already be on master...

And as usual test case would be good to add

@ngs-mtech
Copy link
Contributor Author

I have created the jira to describe the problem: JBPM-6066

As Github says, the branch has no conflicts with the master so these comits may aren't commited yet on the master... :(

Let me think a way to unit test this, may I do a dummy marshalling strategy.

@kie-ci
Copy link

kie-ci commented Jun 19, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@ngs-mtech ngs-mtech force-pushed the master branch 2 times, most recently from 26789f2 to c1ce6d5 Compare July 7, 2017 18:44
@ngs-mtech ngs-mtech changed the title Allow usage of configuration entries in creation of MarshallingStrategies [JBPM-6066] Allow usage of configuration entries in creation of MarshallingStrategies Jul 7, 2017
@mswiderski
Copy link
Contributor

Could you add a test case for this change?

And please remove the document related commit as it is not part of this fix

MarshallingStrategies

Update RuntimeEnvironmentBuilder.java
@ngs-mtech
Copy link
Contributor Author

ngs-mtech commented Jul 12, 2017

Done with the comit removal.

Copy link
Contributor

@mswiderski mswiderski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to have a test for it?

@kiegroup kiegroup deleted a comment from kie-ci Jul 28, 2017
@kiegroup kiegroup deleted a comment from kie-ci Jul 28, 2017
@kiegroup kiegroup deleted a comment from kie-ci Jul 28, 2017
@kie-ci
Copy link

kie-ci commented Aug 8, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

1 similar comment
@kie-ci
Copy link

kie-ci commented Aug 8, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@shami8099
Copy link

hello im interested in learning jbpm can any 1 help me in this

@kie-ci
Copy link

kie-ci commented Oct 9, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

1 similar comment
@kie-ci
Copy link

kie-ci commented Oct 9, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@mswiderski
Copy link
Contributor

lack of response for quite some time ... closing

@mswiderski mswiderski closed this Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants