New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBPM-6066] Allow usage of configuration entries in creation of MarshallingStrategies #866
Conversation
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
3 similar comments
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
ok to test |
@ngs-mtech could you please create jira and describe the problem/improvment need? Looks like you have bunch of commits that should already be on master... And as usual test case would be good to add |
I have created the jira to describe the problem: JBPM-6066 As Github says, the branch has no conflicts with the master so these comits may aren't commited yet on the master... :( Let me think a way to unit test this, may I do a dummy marshalling strategy. |
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
26789f2
to
c1ce6d5
Compare
Could you add a test case for this change? And please remove the document related commit as it is not part of this fix |
MarshallingStrategies Update RuntimeEnvironmentBuilder.java
Done with the comit removal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to have a test for it?
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
1 similar comment
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
hello im interested in learning jbpm can any 1 help me in this |
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
1 similar comment
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
lack of response for quite some time ... closing |
We are using complex deployment descriptors full of configuration entries, but we are not able to use them in creation of object marshalling strategies. With this small change we can define a configuration entry named project_persistence_unit and use it in the calling to the creation of our custom marshalling strategy.