Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOGITO-2284] - Shared libaries: Set maven version #69

Merged
merged 1 commit into from
Jul 6, 2020
Merged

[KOGITO-2284] - Shared libaries: Set maven version #69

merged 1 commit into from
Jul 6, 2020

Conversation

msmagnanijr
Copy link
Contributor

test/vars/MavenSpec.groovy Show resolved Hide resolved
vars/maven.groovy Outdated Show resolved Hide resolved
Copy link
Contributor

@radtriste radtriste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Ginxo Ginxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an indentation problem. LGTM

test/vars/MavenSpec.groovy Outdated Show resolved Hide resolved
See: https://issues.redhat.com/browse/KOGITO-2284

Signed-off-by: Mauricio Magnani <msmagnanijr@gmail.com>
Copy link
Contributor

@Ginxo Ginxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ginxo Ginxo merged commit 57c64eb into kiegroup:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants