[KIECLOUD-221] upgrade datagrid and amq broker versions #172
Conversation
|
Hi @errantepiphany. Thanks for your PR. I'm waiting for a kiegroup or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @tchughesiv |
|
@tchughesiv Please wait to merge until @spolti and @jakubschwan has had a chance to also look at jboss-container-images/rhdm-7-openshift-image#248 and jboss-container-images/rhpam-7-openshift-image#303 . Thanks! |
| ## KIE Servers END |
There was a problem hiding this comment.
Same here, with newline at end of file, if it's removed
There was a problem hiding this comment.
@bmozaffa I've tried everything, and no matter what editor I use (vim, gedit, or even online with the github editor), I can't get a newline to persist at the end of this file. Why is it necessary to be there? And if so, what can I do to add it back?
There was a problem hiding this comment.
Weird, I just submitted a PR against your branch. If you merge it, you can then go back and squash it in and do a push -f?
Without a newline, in some envs you also get a warning when doing a git diff, even when the content is the same near the EOF
There was a problem hiding this comment.
on IntelliJ I had to put 2 blank lines to count one.
Signed-off-by: David Ward <dward@redhat.com>
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmozaffa, errantepiphany The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.jboss.org/browse/KIECLOUD-221
[KIECLOUD-221] upgrade datagrid and amq broker versions
Signed-off-by: David Ward dward@redhat.com