Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KIECLOUD-343] allow product to get routes #310

Merged
merged 1 commit into from Nov 27, 2019
Merged

[KIECLOUD-343] allow product to get routes #310

merged 1 commit into from Nov 27, 2019

Conversation

tchughesiv
Copy link
Member

/assign @sutaakar @bmozaffa

Signed-off-by: tchughesiv tchughesiv@gmail.com

@tchughesiv
[KIECLOUD-343] allow product to get routes
4f79650 
Signed-off-by: tchughesiv <tchughesiv@gmail.com>
@tchughesiv
Copy link
Member Author

@sutaakar @errantepiphany while this PR adds back route access for the product... i've noticed we also removed image.openshift.io group access in that prior change...
https://github.com/kiegroup/kie-cloud-operator/pull/285/files#diff-a5c0693ab31d2c16b6fa64a4d1df72acL772

is there any reason you can think of that this access should be added back... and if so, which resource is needed? imagestreams? imagestreamtags?

@bmozaffa
Copy link
Collaborator

bmozaffa commented Nov 27, 2019 •
edited

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmozaffa, tchughesiv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bmozaffa,tchughesiv]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9bb5c64 into kiegroup:master Nov 27, 2019
@sutaakar
Copy link
Contributor

I am not aware about any needs to have access rights to images.

@tchughesiv tchughesiv deleted the routes branch January 16, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmozaffa bmozaffa Awaiting requested review from bmozaffa

@ruromero ruromero Awaiting requested review from ruromero

Assignees

@bmozaffa bmozaffa

@sutaakar sutaakar

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tchughesiv @bmozaffa @openshift-ci-robot @sutaakar @openshift-merge-robot