[RHPAM-2522] - Provide usable way of setting extensions image named namespace for external DB driver in Operator UI #348
Conversation
…d namespace for external DB driver in Operator UI Signed-off-by: Swati Kale <swkale@redhat.com>
|
Hi @swati-kale. Thanks for your PR. I'm waiting for a kiegroup member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
deploy/ui/form.json
Outdated
| "required": false, | ||
| "jsonPath": "$.spec.objects.servers[*].build.extensionImageStreamTagNamespace", | ||
| "description": "Namespace within which the ImageStream definition for the image containing the drivers and configuration is located. Defaults to openshift namespace.", | ||
| "default": "rhpam-kieserver-library=org.openshift.quickstarts:rhpam-kieserver-library:1.5.0-SNAPSHOT" |
There was a problem hiding this comment.
@spolti changes are done.
Signed-off-by: Swati Kale <swkale@redhat.com>
|
/retest |
deploy/ui/form.json
Outdated
| "type": "text", | ||
| "required": false, | ||
| "jsonPath": "$.spec.objects.servers[*].build.extensionImageInstallDir", | ||
| "description": "scription: Full path to the directory within the extensions image where the extensions are located (e.g. install.sh, modules/, etc. Do not change this field unless you have sure about the changes that you is doing)." |
There was a problem hiding this comment.
| "description": "scription: Full path to the directory within the extensions image where the extensions are located (e.g. install.sh, modules/, etc. Do not change this field unless you have sure about the changes that you is doing)." | |
| "description": "Full path to the directory within the extensions image where the extensions are located (e.g. install.sh, modules/, etc.)." |
There was a problem hiding this comment.
I will do the changes, Do you want the changes in CRD too (https://github.com/kiegroup/kie-cloud-operator/blob/master/deploy/crds/kieapp.crd.yaml#L253)
…amespace for external DB driver in Operator UI Signed-off-by: Swati Kale <swkale@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmozaffa, swati-kale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
updated the Console form UI w.r.t changes against RHPAM-2533 (build config changes in Operator for extensions image settings)
Signed-off-by: Swati Kale swkale@redhat.com