[RHPAM-2658] Define value as byte

[ruromero]

Signed-off-by: Ruben Romero Montes rromerom@redhat.com

Fix https://issues.redhat.com/browse/RHPAM-2658

I have reproduced the issue and validated the fix on the following environment

Server Version: 4.4.0-0.nightly-2020-01-23-054055
Kubernetes Version: v1.17.1

oc create -f deploy/catalog_resources/redhat/1.4.0/businessautomation-operator.1.4.0.clusterserviceversion.yaml                                                                                                  
The ClusterServiceVersion "businessautomation-operator.1.4.0" is invalid: spec.customresourcedefinitions.owned.specDescriptors.value: Invalid value: "": spec.customresourcedefinitions.owned.specDescriptors.value in body must be of type byte: ""

[tchughesiv]

/hold

[tchughesiv]

@ruromero please try to persist this change in tools/csv-gen

kie-cloud-operator/tools/csv-gen/csv-gen.go

Line 224 in 8d246ac

Value: util.RawMessagePointer("false"),

[ruromero]

@tchughesiv I preferred to do it when the value is generated from a string to make it more reusable

[madorn]

@ruromero @tchughesiv - hi folks, just a note that just discovered boolean switch will automatically set this false by default (unless otherwise set to "true" in the CR). It shouldn't be necessary to explicitly set false.

Check out this link: https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/src/components/descriptors/reference/reference.md#4-booleanswitch

[tchughesiv]

thanks @madorn ... thoughts no longer setting to false @ruromero ?

[ruromero]

We can remove the flags but keep the change in the generator. Does that sound right?

[bmozaffa]

Right, though I don't see anything wrong with providing default values either... if anything, it's maybe more explicit and obvious to someone reviewing it.

[tchughesiv]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruromero, spolti, tchughesiv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tchughesiv]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tchughesiv]

/hold cancel

[madorn]

just discovered that completely omitting value will show true on UI if using 4.2.

It will default to false on 4.3 and 4.4

After discussing with UI team, setting the value here is discouraged. We are in the process of getting the docs updated.

In the meantime, completely omit the value field.

To influence the value you have two options:

• Ensure you have desired value set in your CR example within alm-examples section of ClusterServiceVersion: https://github.com/operator-framework/community-operators/blob/master/community-operators/strimzi-kafka-operator/0.14.0/strimzi-cluster-operator.v0.14.0.clusterserviceversion.yaml#L5-L78

• Or set default value within CRD: https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#defaulting