Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHPAM-2746] Set default JVM Max memory ratio to 80% in BA Operator #469

Merged
merged 3 commits into from Jul 29, 2020
Merged

[RHPAM-2746] Set default JVM Max memory ratio to 80% in BA Operator #469

merged 3 commits into from Jul 29, 2020

Conversation

desmax74
Copy link
Member

@desmax74
Copy link
Member Author

@tchughesiv why is checking duplication on code not in the PR ?

jakubschwan
jakubschwan approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@jakubschwan jakubschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it looks OK

@tchughesiv
Copy link
Member

@desmax74 it checks dup against all modified files i believe. maybe you duplicated some existing code?

@desmax74
Copy link
Member Author

@tchughesiv sonar indicate duplication on kieapp_controller_test.go and isn't code in this PR (defaults.go and defaults_test.go)

@tchughesiv
Copy link
Member

/test all

@tchughesiv
Copy link
Member

/hold

@tchughesiv
Copy link
Member

/test all

@tchughesiv
Copy link
Member

/hold cancel
/lgtm
/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desmax74, jakubschwan, tchughesiv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tchughesiv
Copy link
Member

@desmax74 since your cpu PR merged, there appears to be a conflict that needs resolving.

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tchughesiv
Copy link
Member

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 96da7e4 into kiegroup:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchughesiv tchughesiv tchughesiv left review comments

@jakubschwan jakubschwan jakubschwan approved these changes

Assignees

@tchughesiv tchughesiv

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@desmax74 @tchughesiv @openshift-ci-robot @jakubschwan @openshift-merge-robot