Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIECLOUD-420] - Improve the AUTH_LDAP_URL description by adding the … #502

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

spolti
Copy link
Member

@spolti spolti commented Aug 25, 2020

…fail over usage

Signed-off-by: spolti fspolti@redhat.com

@spolti
Copy link
Member Author

spolti commented Aug 25, 2020

@tchughesiv can you please confirm if is there somewhere else I should apply this update?

@spolti spolti force-pushed the KIECLOUD-420 branch 2 times, most recently from 43e9cda to d89c4df Compare August 25, 2020 20:28
deploy/crds/kieapp.crd.v1beta1.yaml Outdated Show resolved Hide resolved
deploy/crds/kieapp.crd.yaml Outdated Show resolved Hide resolved
Copy link
Member

@tchughesiv tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ... remove that one beta crd change and we'll get it merged.

deploy/crds/kieapp.crd.v1beta1.yaml Outdated Show resolved Hide resolved
…fail over usage

Signed-off-by: spolti <fspolti@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@tchughesiv tchughesiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmozaffa, mramendi, spolti, tchughesiv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bmozaffa,tchughesiv]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2ea0b5a into kiegroup:master Aug 26, 2020
@spolti spolti deleted the KIECLOUD-420 branch August 26, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants