Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KIECLOUD-438] - DeploymentConfig probes for BusinessCentral too shor… #554

Merged
merged 1 commit into from Nov 18, 2020
Merged

[KIECLOUD-438] - DeploymentConfig probes for BusinessCentral too shor… #554

merged 1 commit into from Nov 18, 2020

Conversation

Kaitou786
Copy link
Member

…t causing POD Termination

See: https://issues.redhat.com/browse/KIECLOUD-438
Signed-off-by: Tarun Khandelwal tarkhand@redhat.com

[KIECLOUD-438] - DeploymentConfig probes for BusinessCentral too shor…
0e8b51b 
…t causing POD Termination

See: https://issues.redhat.com/browse/KIECLOUD-438
Signed-off-by: Tarun Khandelwal <tarkhand@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@Kaitou786
Copy link
Member Author

/assign tchughesiv

@openshift-merge-robot
Copy link
Collaborator

@Kaitou786: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/configs 0e8b51b link /test configs

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Kaitou786
Copy link
Member Author

@tchughesiv does this needs to be cherry-picked to the release-v7.9.x branch. Since this is targeted for 7.9.1 release ?

@tchughesiv
Copy link
Member

@tchughesiv does this needs to be cherry-picked to the release-v7.9.x branch. Since this is targeted for 7.9.1 release ?

correct

@Kaitou786
Copy link
Member Author

@tchughesiv cherrypick

@tchughesiv
Copy link
Member

/lgtm
/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kaitou786, tchughesiv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tchughesiv tchughesiv merged commit f03593e into kiegroup:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmozaffa bmozaffa Awaiting requested review from bmozaffa

@tchughesiv tchughesiv Awaiting requested review from tchughesiv

Assignees

@tchughesiv tchughesiv

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kaitou786 @openshift-merge-robot @tchughesiv @openshift-ci-robot