Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHPAM-3331] Operator for AMQ Streams (Kafka) integration #614

Merged
merged 1 commit into from Mar 26, 2021
Merged

[RHPAM-3331] Operator for AMQ Streams (Kafka) integration #614

merged 1 commit into from Mar 26, 2021

Conversation

desmax74
Copy link
Member

@desmax74 desmax74 commented Mar 15, 2021 •
edited

@openshift-ci-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

jakubschwan
jakubschwan suggested changes Mar 16, 2021
View reviewed changes
config/7.11.0/common.yaml Outdated Show resolved Hide resolved
deploy/crds/kieapp.crd.yaml Outdated Show resolved Hide resolved
deploy/crds/kieapp.crd.yaml Outdated Show resolved Hide resolved
deploy/crds/kieapp.crd.yaml Outdated Show resolved Hide resolved
deploy/crds/kieapp.crd.yaml Outdated Show resolved Hide resolved
spolti
spolti reviewed Mar 16, 2021
View reviewed changes
config/7.11.0/common.yaml Outdated Show resolved Hide resolved
spolti
spolti suggested changes Mar 16, 2021
View reviewed changes
pkg/apis/app/v2/kieapp_types.go Outdated Show resolved Hide resolved
pkg/apis/app/v2/kieapp_types.go Outdated Show resolved Hide resolved
pkg/apis/app/v2/kieapp_types.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/constants/constants.go Outdated Show resolved Hide resolved
@desmax74 desmax74 force-pushed the rhpam-3331 branch 3 times, most recently from 7b82dc6 to 66de70d Compare March 18, 2021 11:35
@desmax74 desmax74 marked this pull request as ready for review March 18, 2021 11:35
spolti
spolti suggested changes Mar 18, 2021
View reviewed changes
config/7.11.0/common.yaml Outdated Show resolved Hide resolved
deploy/ui/form.json Outdated Show resolved Hide resolved
deploy/ui/form.json Outdated Show resolved Hide resolved
deploy/ui/form.json Outdated Show resolved Hide resolved
pkg/apis/app/v2/kieapp_types.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/constants/constants.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults.go Outdated Show resolved Hide resolved
@desmax74 desmax74 force-pushed the rhpam-3331 branch 3 times, most recently from c5f0e7e to 15734f1 Compare March 19, 2021 10:41
tchughesiv
tchughesiv requested changes Mar 19, 2021
View reviewed changes
config/7.11.0/common.yaml Show resolved Hide resolved
pkg/apis/app/v2/kieapp_types.go Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults.go Outdated Show resolved Hide resolved
@desmax74 desmax74 force-pushed the rhpam-3331 branch 7 times, most recently from 87bc8f9 to e920fe4 Compare March 22, 2021 12:52
spolti
spolti suggested changes Mar 22, 2021
View reviewed changes
pkg/controller/kieapp/constants/constants.go Outdated
@@ -260,6 +260,16 @@ const (
//Envs
KubeNS = "KUBERNETES_NAMESPACE"
KubeLabels = "KUBERNETES_LABELS"

//Kafka extension
KieServerKafkaExtEnabled = "KIE_SERVER_KAFKA_EXT_ENABLED"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides tests where else is this constants being used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for test, moving in the tests

@desmax74 desmax74 force-pushed the rhpam-3331 branch 3 times, most recently from d1cb8ef to 6688118 Compare March 26, 2021 10:11
spolti
spolti reviewed Mar 26, 2021
View reviewed changes
deploy/ui/form.json Outdated Show resolved Hide resolved
spolti
spolti suggested changes Mar 26, 2021
View reviewed changes
pkg/controller/kieapp/defaults/defaults.go Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults_test.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults_test.go Outdated Show resolved Hide resolved
tchughesiv
tchughesiv requested changes Mar 26, 2021
View reviewed changes
deploy/ui/form.json Outdated Show resolved Hide resolved
deploy/ui/form.json Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults.go Show resolved Hide resolved
@tchughesiv
Copy link
Member

@desmax74 fyi
desmax74#6

@desmax74 desmax74 force-pushed the rhpam-3331 branch 4 times, most recently from 704ed24 to 07f0522 Compare March 26, 2021 17:17
tchughesiv
tchughesiv requested changes Mar 26, 2021
View reviewed changes
deploy/ui/form.json Show resolved Hide resolved
@desmax74 desmax74 force-pushed the rhpam-3331 branch 2 times, most recently from fe68b40 to 0c2778b Compare March 26, 2021 20:28
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desmax74, tchughesiv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@desmax74
KAfkaExtension for AMQ (Kafka) streams
705f342 
Signed-off-by: desmax74 <mdessi@redhat.com>
@tchughesiv
Copy link
Member

/lgtm

@sonarcloud
Copy link

sonarcloud bot commented Mar 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
2.5% 2.5% Duplication

@openshift-merge-robot openshift-merge-robot merged commit f1305c0 into kiegroup:main Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolti spolti spolti requested changes

@jakubschwan jakubschwan jakubschwan requested changes

@swati-kale swati-kale swati-kale left review comments

@tchughesiv tchughesiv tchughesiv approved these changes

@ruromero ruromero Awaiting requested review from ruromero

Assignees

@tchughesiv tchughesiv

Labels
approved lgtm release-7.13.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@desmax74 @openshift-ci-robot @spolti @tchughesiv @jakubschwan @swati-kale @openshift-merge-robot