Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHPAM-3623] Turn the StartupStrategy configurable on BA Operator #645

Merged
merged 4 commits into from Aug 6, 2021
Merged

[RHPAM-3623] Turn the StartupStrategy configurable on BA Operator #645

merged 4 commits into from Aug 6, 2021

Conversation

desmax74
Copy link
Member

@desmax74 desmax74 commented Apr 23, 2021 •
edited

@openshift-ci-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: desmax74
To complete the pull request process, please assign bmozaffa after the PR has been reviewed.
You can assign the PR to them by writing /assign @bmozaffa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 27, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@desmax74 desmax74 marked this pull request as ready for review May 27, 2021 17:31
@desmax74 desmax74 marked this pull request as draft May 27, 2021 17:35
@desmax74 desmax74 marked this pull request as ready for review July 5, 2021 20:44
@desmax74 desmax74 marked this pull request as draft July 5, 2021 20:48
@desmax74 desmax74 marked this pull request as ready for review July 14, 2021 17:37
@desmax74 desmax74 marked this pull request as draft July 14, 2021 17:39
spolti
spolti suggested changes Aug 5, 2021
View reviewed changes
config/7.12.0/common.yaml Outdated Show resolved Hide resolved
deploy/crds/kieapp.crd.yaml Outdated Show resolved Hide resolved
deploy/crds/kieapp.crd.yaml Outdated Show resolved Hide resolved
deploy/ui/form.json Outdated Show resolved Hide resolved
pkg/apis/app/v2/kieapp_types.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults.go Outdated Show resolved Hide resolved
@desmax74 desmax74 force-pushed the RHPAM-3623 branch 2 times, most recently from 6f16156 to 3d87d3c Compare August 5, 2021 15:49
spolti
spolti suggested changes Aug 5, 2021
View reviewed changes
deploy/crds/kieapp.crd.yaml Outdated Show resolved Hide resolved
deploy/crs/v2/snippets/common_config.yaml Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults_test.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults_test.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults_test.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults_test.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults_test.go Outdated Show resolved Hide resolved
@desmax74 desmax74 force-pushed the RHPAM-3623 branch 2 times, most recently from 54205b6 to 7c9cc0d Compare August 5, 2021 17:04
spolti
spolti suggested changes Aug 5, 2021
View reviewed changes
deploy/crs/v2/snippets/common_config_openshiftStartupStrategy.yaml Outdated Show resolved Hide resolved
deploy/crs/v2/snippets/common_config_controllerBasedStartupStrategy.yaml Outdated Show resolved Hide resolved
pkg/apis/app/v2/kieapp_types.go Outdated Show resolved Hide resolved
pkg/apis/app/v2/kieapp_types.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults_test.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults_test.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults_test.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults_test.go Outdated Show resolved Hide resolved
@desmax74 desmax74 force-pushed the RHPAM-3623 branch 4 times, most recently from e103c80 to 607c956 Compare August 5, 2021 18:51
@desmax74
Turn the StartupStrategy configurable on BA Operator
3c5eb3f 
Signed-off-by: desmax74 <mdessi@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desmax74, jakubschwan, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@spolti
Copy link
Member

spolti commented Aug 6, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 6, 2021
@openshift-ci openshift-ci bot merged commit a51eb8b into kiegroup:main Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchughesiv tchughesiv tchughesiv left review comments

@spolti spolti spolti approved these changes

@jakubschwan jakubschwan jakubschwan approved these changes

Assignees

@spolti spolti

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@desmax74 @openshift-ci-robot @spolti @tchughesiv @jakubschwan