Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHPAM-4125] Add capability to configure Route termination #764

Merged
merged 1 commit into from Mar 25, 2022

Conversation

desmax74
Copy link
Member

Signed-off-by: desmax74 mdessi@redhat.com

pkg/apis/app/v2/kieapp_types.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults.go Outdated Show resolved Hide resolved
pkg/controller/kieapp/defaults/defaults.go Outdated Show resolved Hide resolved
@desmax74 desmax74 marked this pull request as draft March 25, 2022 13:01
@desmax74 desmax74 marked this pull request as ready for review March 25, 2022 13:13
Copy link
Contributor

@jakubschwan jakubschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor thing, otherwise it looks good

pkg/controller/kieapp/defaults/defaults_test.go Outdated Show resolved Hide resolved
Signed-off-by: desmax74 <mdessi@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desmax74, jakubschwan, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spolti
Copy link
Member

spolti commented Mar 25, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 25, 2022
@openshift-merge-robot openshift-merge-robot merged commit 60a3bbe into kiegroup:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants