Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-10164] Adding millisecond date type support to dialects #265

Merged
merged 1 commit into from Mar 24, 2023

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Mar 9, 2023

Thank you for submitting this pull request

JIRA:

link

@fjtirado fjtirado requested a review from gmunozfe March 9, 2023 11:42
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, superb work @fjtirado !
Just one question about it

@fjtirado fjtirado added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Mar 9, 2023
@Ginxo
Copy link
Contributor

Ginxo commented Mar 22, 2023

Jenkins retest this

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.8% 77.8% Coverage
80.0% 80.0% Duplication

@fjtirado fjtirado merged commit 35bea7a into kiegroup:main Mar 24, 2023
8 of 9 checks passed
fjtirado added a commit that referenced this pull request Mar 30, 2023
…267)

Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
fjtirado added a commit that referenced this pull request Mar 30, 2023
…266)

Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants