Bring back Git URL external access of the current project #1536
Conversation
|
jenkins full downstream build |
| @@ -35,7 +35,7 @@ <h3 data-i18n-key="GeneralSettings" data-field="title"></h3> | |||
| </div> | |||
| <div class="form-group"> | |||
| <label for="url" data-i18n-key="URL"></label> | |||
| <input type="text" class="form-control" id="url"> | |||
| <input type="text" class="form-control" id="url" readonly> | |||
There was a problem hiding this comment.
By making this field read-only this PR is changing the semantics of the URL field in general settings.
Before this PR this field was connected to project pom.xml <url> element.
In this PR this has changed to dynamically display URL of the workbench-managed repository.
This means that we should remove this outdated functionality from GeneralSettings presenter.
There was a problem hiding this comment.
the semantic of the URL was always intented to be the one present in this PR, use the pom data wasn't the original intentention.
ps: I was part of the UI design and personally asked UX to add this field to cover exactly the Git URL. This was overlooked during the merge.
| //this is basically for tests that don't use git file system | ||
| } | ||
|
|
||
| model.setGitUrl(value.replace("\n", " | ")); |
There was a problem hiding this comment.
Does this mean that getFilesystem().toString() is returning multiple lines with 1 url per line? I find that a bit confusing.. Could you please point me to some code where we're setting URL to contain newline-separated URLs? I'd like to understand this better.
Also it would be nice to have a unit test for this new loading behavior here
There was a problem hiding this comment.
This has always been the behavior of the jgit getFilesystem().toString(), here link for the code: https://github.com/kiegroup/appformer/blob/master/uberfire-nio2-backport/uberfire-nio2-impls/uberfire-nio2-jgit/src/main/java/org/uberfire/java/nio/fs/jgit/JGitFileSystemImpl.java#L104-L117
About the test: yes... ideally the test should cover this, but to make this happen this test has to be completely redone to use git not "file://" - and to do this it wouldn't be possible for the release happening today. I'd prefer to have this quick and dirty fix merged to be part of the community release and then follow up and fix the test.
… UX of workbench: display the git external access url's. this initial implementation aims to be a quick hack, enabling this long time request available for upcoming release. It's expected to improve the UI visulation, bringing something like GitHub has.
There was a problem hiding this comment.
Approving this PR after discussion with @porcelli - the followup work (changing this quick impl to 2 readonly inputs with "copy to clip board" button, adding a test for this and removing the obsolete "set url in pom.xml") will be implemented later as part of AF-1113.
this initial implementation aims to be a quick hack, enabling this long time request available for upcoming release.
It's expected to improve the UI visulation, bringing something like GitHub has.