JBPM-7162: Stunner - Make canvas size configurable (via workbench preferences) #1714
Conversation
|
@romartin @hasys Hi, would you mind review this PR? @romartin I've set the maximum accepted values for the canvas size two times the one we already had. This was more or less what we talked about. But since you have more background/experience around the performance issues please take a look, and let me know if we need an adjustment, or if this max values can even be increased. |
|
Jenkins execute full downstream build |
|
Jenkins execute full downstream build |
2 similar comments
|
Jenkins execute full downstream build |
|
Jenkins execute full downstream build |
| StunnerDiagramEditorPreferences.AutoHidePalettePanel.Help=Enables the automatically hiding of the toolbar panel associated with a Category. E.g. when a category item is selected, or when the mouse leaves the panel. | ||
| StunnerDiagramEditorPreferences.CanvasWidth.Label=Drawing area width | ||
| StunnerDiagramEditorPreferences.CanvasWidth.Help=Sets the width of the editor drawing area. It must be an integer number between 2800 and 5600. |
There was a problem hiding this comment.
Would be possoble to replace constants 2800 ... with something like {0} ... and then during construction of the real string use the constants from CanvasWidthValidator and CanvasHeightValidator ?
There was a problem hiding this comment.
@jomarko The preferences API doesn't have the ability of accepting/processing {xxx} parameters in the validators, so it's not possible at this point.
| intValue = Integer.parseInt(value); | ||
| } catch (NumberFormatException e) { | ||
| return new ValidationResult(false, | ||
| messagesBundleKeys()); |
There was a problem hiding this comment.
Just minor thing, but I think NumberFormatException doesn't mean out of the range.
There was a problem hiding this comment.
@jomarko I see the point, but see that validations are chained and the preferences api first checks if the value is a valid number, and then "transfers the execution" to the next validator. So if a wrong number is typed, this validator is not executed, and a proper message is automatically set. Since I still need to parse the value, I need to do something in case the exception is throw, but this case will probably never happen. I believe we can live with that. We'll also move to infinite canvases as asap, so this canvas size preferences will be removed asap too.
| @@ -31,6 +31,8 @@ | |||
| @Override | |||
| public StunnerPreferences defaultValue(final StunnerPreferences defaultValue) { | |||
| defaultValue.diagramEditorPreferences.setAutoHidePalettePanel(false); | |||
| defaultValue.diagramEditorPreferences.setCanvasWidth(2800); | |||
There was a problem hiding this comment.
I think we could use CanvasWidthValidator.MIN_CANVAS_WIDTH
There was a problem hiding this comment.
@jomarko I don't think so. The MIN_VALUE is the lower bound. i.e., we don't want users to try to set the value lower than this minimum. But instead the by default value is what we "believe" is "the best value" to start working with. Then the user has the freedom of changing.
| @@ -31,6 +31,8 @@ | |||
| @Override | |||
| public StunnerPreferences defaultValue(final StunnerPreferences defaultValue) { | |||
| defaultValue.diagramEditorPreferences.setAutoHidePalettePanel(false); | |||
| defaultValue.diagramEditorPreferences.setCanvasWidth(2800); | |||
| defaultValue.diagramEditorPreferences.setCanvasHeight(1400); | |||
There was a problem hiding this comment.
I think we could use CanvasHeightValidator.MIN_CANVAS_HEIGHT
…ferences) (kiegroup#1714) (cherry picked from commit ccb3da7)
No description provided.