Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.7.x] DROOLS-2526 : [Test Scenario][IE] Can't be run #1745

Merged

Conversation

Rikkola
Copy link
Member

@Rikkola Rikkola commented May 4, 2018

(cherry picked from commit 026ac59)

https://issues.jboss.org/browse/DROOLS-2526

Same as the one in master. This just had one import conflict that I had to fix.

IE did not select a value by default, other browsers did. I changed the KSessionSelector to use the latest dropdown codes we have. The real changes are in KSessionSelector, everything else is just there since I had to move the dropdown base to the commons project.

@manstis @jomarko You two might be the best ones to review this, thank you.

ping @barboras7

Bundle:
#1745
kiegroup/jbpm-wb#1115

@manstis manstis requested a review from jomarko May 4, 2018 11:06
@barboras7
Copy link
Contributor

Jenkins execute full downstream build

1 similar comment
@Rikkola
Copy link
Member Author

Rikkola commented May 4, 2018

Jenkins execute full downstream build

@jomarko
Copy link

jomarko commented May 4, 2018

jenkins execute full downstream build

@Rikkola
Copy link
Member Author

Rikkola commented May 4, 2018

The error mentioned jbpm workspaces. Building locally to see if I broke anything there. Strange if I did, since the kie-wb-distributions build worked fine earlier today.

@jomarko
Copy link

jomarko commented May 4, 2018

@Rikkola also me building locally, would like to approve today

@Rikkola
Copy link
Member Author

Rikkola commented May 4, 2018

Looks like jbpm-wb uses ListItemView. Making a fix. I wonder if master does the same. Strange that my local war build still passed.

@jomarko
Copy link

jomarko commented May 4, 2018

@Rikkola very strange, also me built locally without complaining about inconsistency in jbpm-wb, anyway, can confirm original issue with running test scenarios has gone, so please let me know when you are done with changes, I will go trough other places where the select box was changed, or if you think necessarry to merge today, feel free do not wait for my re-review and I will check on monday.

@Rikkola
Copy link
Member Author

Rikkola commented May 4, 2018

@jomarko I compiled jbpm-wb locally and then I got errors. Added made a PR.

@Rikkola
Copy link
Member Author

Rikkola commented May 4, 2018

@jomarko This might have to wait for Monday just because of the speed of the build servers.

@Rikkola
Copy link
Member Author

Rikkola commented May 4, 2018

Building all the -wb projects locally, just in case.

@cristianonicolai
Copy link
Contributor

Jenkins execute full downstream build

@Rikkola
Copy link
Member Author

Rikkola commented May 5, 2018

Can't see what the actual cause for failure is, but just in case restarting. I'll be able to look tomorrow evening.

Jenkins execute full downstream build

@Rikkola
Copy link
Member Author

Rikkola commented May 6, 2018

Nice!

@cristianonicolai cristianonicolai merged commit b378ff4 into kiegroup:7.7.x May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants