Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stunner - (Un)Marshaller tests for End Events #1832

Merged
merged 6 commits into from Jun 1, 2018

Conversation

LuboTerifaj
Copy link
Contributor

No description provided.

@LuboTerifaj
Copy link
Contributor Author

Note, that new marshaller tests are commented out because they are failing. Reported Jira about it: https://issues.jboss.org/browse/JBPM-7312

@LuboTerifaj
Copy link
Contributor Author

Hi @romartin, @evacchi, @hasys
Can you please have a look?
Thank you!

@evacchi
Copy link
Contributor

evacchi commented May 25, 2018

Hi @LuboTerifaj code looks fine as usual, I'll folow up with a fix as soon as this gets merged!

@romartin romartin requested review from evacchi and romartin May 28, 2018 19:46
@romartin
Copy link
Contributor

Jenkins please retest this

@romartin
Copy link
Contributor

Jenkins please retest this

@hasys
Copy link
Member

hasys commented May 30, 2018

Jenkins execute full downstream build

Copy link
Member

@hasys hasys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LuboTerifaj,

looks very good to me, thank you!

@romartin
Copy link
Contributor

Jenkins please retest this

@romartin romartin merged commit caa6cd5 into kiegroup:master Jun 1, 2018
LuboTerifaj added a commit to LuboTerifaj/kie-wb-common that referenced this pull request Jun 4, 2018
* (Un)Marshaller tests for End None Events
* (Un)Marshaller tests for End Signal Events
* (Un)Marshaller tests for End Error Events
* (Un)Marshaller tests for End Message Events
* Change formatting in End Message Event tests
* (Un)Marshaller tests for End Terminate Events

(cherry picked from commit caa6cd5)
jomarko pushed a commit to jomarko/kie-wb-common that referenced this pull request Aug 3, 2018
* (Un)Marshaller tests for End None Events
* (Un)Marshaller tests for End Signal Events
* (Un)Marshaller tests for End Error Events
* (Un)Marshaller tests for End Message Events
* Change formatting in End Message Event tests
* (Un)Marshaller tests for End Terminate Events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants