Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.7.x] RHPAM-1104: Stunner - 'Task name' is for internal use and mustn't be editable for ServiceTasks #1833

Merged
merged 1 commit into from Jun 1, 2018
Merged

[7.7.x] RHPAM-1104: Stunner - 'Task name' is for internal use and mustn't be editable for ServiceTasks #1833

merged 1 commit into from Jun 1, 2018

Conversation

wmedvede
Copy link
Member

No description provided.

@wmedvede
Copy link
Member Author

Hi @romartin @hasys let's this PR build, etc., and have this prepared just in case there are time for any last moment cherry-pick into the 7.0.0.GA.

@wmedvede
Copy link
Member Author

well, to late to get this into the 7.0.0, but let's keep this to merge it in as soon we get the green light for starting the 7.0.1

@hasys
Copy link
Member

hasys commented May 29, 2018

Jenkins execute full downstream build

hasys
hasys approved these changes May 31, 2018
View reviewed changes
Copy link
Member

@hasys hasys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wmedvede,

looks and works good!

@wmedvede
Copy link
Member Author

wmedvede commented Jun 1, 2018

Hello @hasys @romartin , I believe this PR is not "temporal" any more and we would like to have this in for the upcoming 7.0.1.
@romartin would you mind take a look? (@hasys has already approved)
Thanks.

@wmedvede wmedvede changed the title [DON'T MERGE - 7.7.x] RHPAM-1104: Stunner - 'Task name' is for internal use and mustn't be editable for ServiceTasks [7.7.x] RHPAM-1104: Stunner - 'Task name' is for internal use and mustn't be editable for ServiceTasks Jun 1, 2018
@romartin
Copy link
Contributor

romartin commented Jun 1, 2018

Hey @krisv
I think to get this merged it's missing some ACK here -> https://issues.jboss.org/browse/RHPAM-1104, the devel one, is it? Can you set it please? Thx

@romartin romartin merged commit 9995106 into kiegroup:7.7.x Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasys hasys hasys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wmedvede @hasys @romartin