Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROOLS-2721: [DMN Designer] InputData node can not be connected to BKM node #1963

Merged
merged 1 commit into from Jul 11, 2018
Merged

DROOLS-2721: [DMN Designer] InputData node can not be connected to BKM node #1963

merged 1 commit into from Jul 11, 2018

Conversation

manstis
Copy link
Member

@manstis manstis commented Jul 11, 2018

See https://issues.jboss.org/browse/DROOLS-2721

@jomarko I also tested this fix with #1955 and it worked OK.

@manstis manstis requested review from karreiro and jomarko July 11, 2018 12:26
@jomarko
Copy link

jomarko commented Jul 11, 2018

Approved without manual check, will manul check as part of #1955

Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @manstis :-)

@manstis manstis merged commit 9dd3217 into kiegroup:master Jul 11, 2018
@jomarko
Copy link

jomarko commented Jul 12, 2018

@manstis user is now not able to store diagram where InputData is connected to BKM because BusinessKnowledgeModelConverter throws and error on this line

Not sure if the BusinessKnowledgeModelConverter has to be updated or this PR reverted.

@manstis
Copy link
Member Author

manstis commented Jul 12, 2018

@jomarko I am tempted to revert. The OMG DMNv1.1 Specification states:

6.2.2.1 Information Requirement notation
Information Requirements may be drawn from Input Data elements to Decisions, and from Decisions to other Decisions. They represent the dependency of a Decision on information from input data or the results of other Decisions...

No mention of BKMs at all. Let me chat with @tarilabs to understand.

manstis added a commit that referenced this pull request Jul 12, 2018
…ed to BKM node (#1963)" (#1967)

OMG DMNv1.1 Specification states InformationRequirements apply to only Decision nodes.

This reverts commit 9dd3217.
tiagodolphine pushed a commit to tiagodolphine/kie-wb-common that referenced this pull request Jul 13, 2018
tiagodolphine pushed a commit to tiagodolphine/kie-wb-common that referenced this pull request Jul 13, 2018
…ed to BKM node (kiegroup#1963)" (kiegroup#1967)

OMG DMNv1.1 Specification states InformationRequirements apply to only Decision nodes.

This reverts commit 9dd3217.
jomarko pushed a commit to jomarko/kie-wb-common that referenced this pull request Aug 3, 2018
jomarko pushed a commit to jomarko/kie-wb-common that referenced this pull request Aug 3, 2018
…ed to BKM node (kiegroup#1963)" (kiegroup#1967)

OMG DMNv1.1 Specification states InformationRequirements apply to only Decision nodes.

This reverts commit 9dd3217.
jeremyary pushed a commit to jeremyary/kie-wb-common that referenced this pull request Aug 31, 2018
jeremyary pushed a commit to jeremyary/kie-wb-common that referenced this pull request Aug 31, 2018
…ed to BKM node (kiegroup#1963)" (kiegroup#1967)

OMG DMNv1.1 Specification states InformationRequirements apply to only Decision nodes.

This reverts commit 9dd3217.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants