[AF-1407-7.7.x]: git import is not backward compatible #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrielparedes
force-pushed
the
AF-1407-7.7.x
branch
from
72c9684
to
1cec63c
Compare
|
Build finished. 8029 tests run, 31 skipped, 0 failed. |
|
just formal question, can you change the commit message to not duplicate the referenced AF-1407 jira? Instead of that please use RHPAM-1413 to be identified by JIRA integration properly? |
|
@mareknovotny AppFormer just uses community JIRAs references. the same commit messages will be ok as during squash can be fixed the commit message |
|
well, it will be still duplicated if you don't change PR title here. |
adrielparedes
force-pushed
the
AF-1407-7.7.x
branch
3 times, most recently
from
c3e1c38
to
e39d3bf
Compare
…added an attribute to enable or disable validations
adrielparedes
force-pushed
the
AF-1407-7.7.x
branch
from
e39d3bf
to
f2e3668
Compare
porcelli
approved these changes
Jul 23, 2018
|
@mareknovotny can we wait until tomorrow to @tomasdavidorg take a look on this? He already approved this PR on master, but we did some changes in order to make it simpler. |
ederign
approved these changes
Jul 23, 2018
|
@ederign yes, we can wait for @tomasdavidorg's review |
tomasdavidorg
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Mandatory dependencies validator and Plugin validator. They will be improved and added again in a future.