JBPM-7689: Focus canvas after node selection in DMN navigator dock #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! Looks good to me, thank you @jomarko |
hasys
approved these changes
Sep 7, 2018
manstis
reviewed
Sep 7, 2018
| @@ -55,7 +56,8 @@ | |||
| import static org.mockito.Mockito.when; | |||
|
|
|||
| @RunWith(GwtMockitoTestRunner.class) | |||
| public class DecisionNavigatorBaseItemFactoryTest { | |||
| public class | |||
| DecisionNavigatorBaseItemFactoryTest { | |||
There was a problem hiding this comment.
We don't usually split this on to two lines.. but it's cosmetic (I'll be surprised if the checkstyle plugin passes!)
There was a problem hiding this comment.
@manstis It should pass, checkstyle doesn't check stuff like this. It checks not used imports, tab symbols, if/for/while without curly braces and things like this. All stylish moments delegated to IDE formatter.
There was a problem hiding this comment.
I am surprised how does this get in? :D will update definitely. Thanks for spotting.
|
Forced pushed changes, hope jenkins will be fine with them. |
|
@manstis please merge when you have a moment. |
manstis
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@manstis @hasys please have a look, one more case to check.