DROOLS-3243: [DMN Designer] Move the Data Type dialog to a tab in the DMN editor

[karreiro]

See:

• https://issues.jboss.org/browse/DROOLS-3243
• https://issues.jboss.org/browse/DROOLS-3056

---

DROOLS-3243:

DROOLS-3056:
The core of the performance enhancement in this PR lives in the DataTypeListItemView. All @DataFields are lazy now, this decision makes the code more prolix but considerably increases the performance.

Before this improvement, the instantiation of a DataTypeListItem in the DataTypeList was taking ~29ms*, and now it takes less than ~9ms, it has a significant impact when the DMN file has a lot a Data Types.

For the scenario that Jozef raised here, the remove operation still holds a small delay but a considerable improvement can be noticed.

The next (and final improvement) will be an enhancement in the algorithm that elects the dependent Data Types in the ItemDefinitionRecordEngine. However, for now, I do think that the current optimisations are good enough.

* The title of the JIRA says 100ms, but I could make some optimisations before starting the real work in the JIRA.

[jomarko]

Some comments to code

[jomarko]

I see two vertical scrollbars on right site is it expected?

[jomarko]

It seems we have again issue that not all data type definitions are visible:

[jomarko]

If user navigates to Data Types tab from Boxed expression, the NameAndDataType popup remains shown.

@jomarko @karreiro See my comment here.

[jomarko]

Save of whole diagram doesn't shown FlashMessages. Please follow my steps.

• Open Data Types tab
• Add tNum:number Item Definition, save it inline
• Add new Item Definition, put tNum into name input field
• Try to save inline - Flash message will be thrown
• Try to save globally - whole diagram - no message will be thrown

[jomarko]

Global save doesn't cancel edit operation of particular item definitions, please follow my steps:

• Click data types tab
• Add item definition
• Fill name and type, don't click save inline - keep edit mode active
• Click global asset save
• Edit mode of item definition remains active, however if you reopen diagram, previously defined item definition will be stored

I think we should cancel edit mode of item definitions if global save was clicked

[jomarko]

@karreiro thanks for PR, really nice coverage and performance seems to be really better! However I would like to ask you to check comments above before approval.

[karreiro]

@jomarko Thank you for the review. I'm already working in your comments. :-)

[karreiro]

Thank you for the review @manstis @jomarko. Changes applied.

@jomarko,

Regarding the issues, you mentioned above.

1) Scroll bars issue

Fixed:

---

2) Some data type definitions are not visible
Fixed:

---

3) The NameAndDataType popup is not closed when the user navigates to the Data Types tab
Fixed:

---

4) About these two topics:
a) Save of the whole diagram doesn't show FlashMessages
b) Global save doesn't cancel edit operation of particular item definitions

I don't see both as issues. They look like the expected behavior. I think we could raise a JIRA (involving Liz) to discuss more them, and eventually, implement the discussed approach in a future PR. Wdyt?

[jomarko]

@karreiro thank you, I am going to re-review quickly today, could you please add point 4) to our weekly meeting agenda?

[jomarko]

Manual check pending

[jomarko]

@karreiro I can confirm 1) 2) and 3) works great now. Approving regardless of answers on my questions.

[karreiro]

@jomarko Thank you. I've extracted the constants for the page indexes as suggested.

[manstis]

Just a couple of follow up questions.

Liking what you did to DataTypeListItemView -- I guess the Errai binding takes a ton of time!

[karreiro]

@manstis Changes applied.

[manstis]

Thanks @karreiro :-)