DROOLS-2883: [DMN Designer] Add a Search bar in the Data Type dialog for search top level custom Data Types / DROOLS-3030: [DMN Designer] Expand / Collapse all

[karreiro]

See:

• https://issues.jboss.org/browse/DROOLS-2883
• https://issues.jboss.org/browse/DROOLS-3030

---

DROOLS-2883:

DROOLS-3030:

[manstis]

Jenkins please retest this (now the BPMN2 file indexer test is fixed)

[manstis]

Code looks OK to me; however I can break it quite easily:

• Launch workbench/webapp
• Create new DMN file
• Select "Data Type" tab
• Add 'a'
• Add 'b'
• Search for 'a' ('a' is shown, 'b' is not. Great!). Do not clear/reset search
• Click Add
• New item not shown
• Clear/reset search and they appear (so search is acting more like a "dynamic filter")
• Select one of the new items created (that was hidden) and "Remove" it
• "No custom Data Types found" shown. Need to clear/reset search (again)
• Repeat..
• Click expand/collapse NPE.

[jomarko]

@karreiro postponing my review until you address Michael's comments to avoid spotting the same.

[karreiro]

Thank you, @manstis.

Regarding the issue when the user adds a new Data Type.. I'm reseting the search bar in this scenario. When users are filtering data types, they are looking for something, and when they are creating a new top-level DT, they don't need to keep the old search.

About the bug related to the "Remove" operation.. the search bar exposed an existing issue, the DROOLS-3329. It's fixed now.

Finally, the NPE with expand/collapse was related to the DROOLS-3329 too.

Thus, changes applied :-) Thanks!

---

@jomarko Feel free to take a look now ;-)

[jomarko]

@karreiro HI, found one minor issue on edge DROOLS-3426. And here are some comments with questions, proposals, let me know if I should file jiras for them.

• Expand/Collapse doesn't execute action if filtering is active, could we disable (grey color) them when filtering is active
• The allowed edit actions when filtering is active. It is tightly connected with DROOLS-3015. I see filtering as the way for finding a data type that I want to update in some way. The problem is when I find a data type and update it the result is visible to me just if it mathes the current filter. I think we need to define in more advance level what should happen when user filter for some data type and starts edit it, let me know what do you think.

Otherwise works fine. Tested manually, still need to check code.

[manstis]

Works well now; thanks @karreiro

[jomarko]

Code looks fine

[manstis]

@jomarko If the code is fine and you've tested manually could you please approve the PR?

[karreiro]

@manstis Thank you ;-)

---

@jomarko Thank you!

Regarding the "Expand/Collapse" improvement, I think we can handle this in a separated JIRA.

Also, about the filter behavior (we the user updates a DT), personally I think that the current operation looks like something I expect as a user. But, we can create a UX JIRA to have a broader discussion there about it (but, for now, I think that we're fine).