JBPM-8903 : Stunner - Properties panel is not opened after clicking on "Minimize panel" button #3127
Conversation
|
Jenkins execute full downstream build |
2 similar comments
|
Jenkins execute full downstream build |
|
Jenkins execute full downstream build |
|
@romartin @LuboTerifaj This is scoped for 7.7 - please review |
|
Jenkins execute full downstream build |
|
@inodeman can you please generate the |
|
Jenkins execute full downstream build |
|
War can be downloaded here |
|
Hi @romartin war was uploaded, can you review it? |
|
thanks @inodeman . Anyway now FDB is green, so @LuboTerifaj can also start the review. Pllease guys, tthat's a priority for product. Thanks! |
There was a problem hiding this comment.
Hello @inodeman ,
I have found a few issues:
-
Properties panel is open instead of Explore Diagram panel.
Steps to reproduce:- Ensure that Properties panel is open.
- Maximize panel.
- Open Explore Diagram panel.
- Minimize panel.
-
Explore diagram panel is not open. There is also an animation that is not needed.
Steps to reproduce:- Ensure that Explore diagram panel is open.
- Maximize panel.
- Minimize panel.
-
There is an animation that is not needed.
Steps to reproduce:- Ensure that Properties panel is closed.
- Maximize panel.
- Open Properties or Explore Diagram panel.
- Minimize panel.
One thought came to my mind. It is not clear, what behaviour should be implemented when switching between different assets. However this cannot be resolved until https://issues.redhat.com/browse/JBPM-8915 is done. I consider it as out of scope of the jira.
Can you please have a look at my findings?
Thank you!
|
Hello @inodeman , I have found one more issue. Switch to full screen mode, close Properties panel and then repeat 3 times:
After that, execute just first two steps. |
|
Hi @LuboTerifaj some of those issues I think happen with or without this PR, I think we should create Jira for it. Now for the Explore Panel I did not see it mentioned on the Ticket, also the behaviour about when the window is maximized and the user clicks properties panel and then on minimize does seem logical but was not mentioned previously. I think I can do the Explore Panel plus the behaviour of user clicking on Properties when Maximized in a few hours, but in case it takes more, I think could be a good idea to merge the PR and add the issues on Jiras, what do you think Lubo, @romartin ? |
|
@LuboTerifaj I saw the issue you comment about the panel being shifted, it is due to Uberfire and its docks it seems, although it only shows for about half a second and then it goes back to normal in my case. Now, I have seen from time to time that issue you comment where it just stays shifted. On your case is it reproducible 100% of the time? I mean that it stays shifted? Also, the animation that is not needed seems it also comes from Uberfire, where it tries to minimize the main panel as if it was going to open properties panel but then it closes. I will research a bit more |
|
Jenkins execute full downstream build |
|
Hi @LuboTerifaj I added the functionality you mentioned on the Explore Panel, so it should work now, about all other issues can we create other Jiras for them? let me know |
|
Jenkins execute full downstream build |
|
Hello @inodeman , can you apply kie code style formatting on your code please? Thanks! |
|
@inodeman plz reformat code andl let us know agian. Thx! |
There was a problem hiding this comment.
Hello @inodeman ,
I've reported the issues:
JBPM-9005 Maximize and minimize panel in full screen mode shifts the whole designer
JBPM-9004 Redundant animation is shown after panel is minimized
JBPM-9003 Properties panel is open instead of Explore Diagram panel
Once, the proper code style is applied it will be ready to merge.
Thanks!
…n "Minimize panel" button
|
Jenkins execute full downstream build |
|
Hi @LuboTerifaj @romartin I re-checked the formatting and I have it set as KIE by default, changed a couple of conflicting issues, I think should be fine now, let me know |
|
Jenkins retest this |
|
ok @LuboTerifaj please missing your final review! thx. |
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Hello @inodeman ,
the kie code style has not been applied in the all changed files.
See inline comments for more information.
However, it doesn't affect quality of implemented fix, hence I am for merging the pull-request.
Thanks!
| @@ -172,7 +172,7 @@ public void checkDestructionReleasesResources() { | |||
|
|
|||
| @Test | |||
| public void checkOnScreenMaximisedDiagramEditor() { | |||
| final ScreenMaximizedEvent event = new ScreenMaximizedEvent(true); | |||
| final ScreenMaximizedEvent event = new ScreenMaximizedEvent(true ); | |||
There was a problem hiding this comment.
| final ScreenMaximizedEvent event = new ScreenMaximizedEvent(true ); | |
| final ScreenMaximizedEvent event = new ScreenMaximizedEvent(true); |
| super.doOpen(); | ||
| .filter(dock -> dock.getPlaceRequest().getIdentifier().compareTo(id) == 0) | ||
| .forEach(action); | ||
|
|
|
|
||
| private final boolean isExplorerScreen; | ||
|
|
||
| public ScreenPreMaximizedStateEvent(final boolean isExplorerScreen ) { |
There was a problem hiding this comment.
| public ScreenPreMaximizedStateEvent(final boolean isExplorerScreen ) { | |
| public ScreenPreMaximizedStateEvent(final boolean isExplorerScreen) { |
Hi @romartin Can you review this PR?