Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AF-2422] Fixed path issues (Windows OS) #3141

Merged
merged 1 commit into from
Feb 6, 2020
Merged

[AF-2422] Fixed path issues (Windows OS) #3141

merged 1 commit into from
Feb 6, 2020

Conversation

caponetto
Copy link
Member

Task: AF-2422

Issue: Business central is not starting up properly in Windows OS due to path issues.

Expected behavior: Starting up business central normally.

@ederign
Copy link
Member

ederign commented Feb 4, 2020

@caponetto can you please provide also a war for this?
@Rikkola would you mind to please verify if this fixes your issue?

@ederign
Copy link
Member

ederign commented Feb 4, 2020

@caponetto can you please provide also a war for this?
@Rikkola would you mind to please verify if this fixes your issue?

@ederign
Copy link
Member

ederign commented Feb 4, 2020

please jenkins execute full downstream build

@caponetto
Copy link
Member Author

Here's a war file with the changes included.

@caponetto
Copy link
Member Author

The failed test is unrelated (it has failed in other PR as well).

@Rikkola Rikkola self-requested a review February 5, 2020 08:53
Copy link
Member

@Rikkola Rikkola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me in Window.s

@caponetto
Copy link
Member Author

Jenkins retest this please

@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@sthundat sthundat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Business central is starting normally in windows as expected

@ederign
Copy link
Member

ederign commented Feb 6, 2020

Test fail is not related and we got a green fdb

@ederign ederign merged commit e9d9e6d into kiegroup:master Feb 6, 2020
@caponetto caponetto deleted the AF-2422-master branch February 6, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants