New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DROOLS-3843: [DMN Editor] Decision Navigator differentiate icons for DRGElement #3257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vpellegrino Congratulations for your first PR! It looks fine to me, just a couple of things.
...test/java/org/kie/workbench/common/dmn/client/docks/navigator/DecisionNavigatorItemTest.java
Show resolved
Hide resolved
.../kie/workbench/common/dmn/client/docks/navigator/factories/DecisionNavigatorItemFactory.java
Show resolved
Hide resolved
jenkins execute full downstream build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question to code.
...java/org/kie/workbench/common/dmn/client/docks/navigator/tree/DecisionNavigatorTreeView.less
Show resolved
Hide resolved
jenkins execute full downstream build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @vpellegrino!
Please refer to: https://issues.redhat.com/browse/DROOLS-3843
Preview: