Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROOLS-3843: [DMN Editor] Decision Navigator differentiate icons for DRGElement #3257

Merged
merged 8 commits into from Apr 3, 2020

Conversation

vpellegrino
Copy link
Contributor

Copy link
Member

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vpellegrino Congratulations for your first PR! It looks fine to me, just a couple of things.

@vpellegrino
Copy link
Contributor Author

jenkins execute full downstream build

@vpellegrino vpellegrino requested a review from yesamer April 2, 2020 14:41
Copy link

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question to code.

@vpellegrino
Copy link
Contributor Author

jenkins execute full downstream build

@vpellegrino vpellegrino requested a review from jomarko April 3, 2020 13:38
Copy link

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked environments:

  • VS Code
  • chrome
  • firefox

Thank you @vpellegrino

Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vpellegrino!

@karreiro karreiro merged commit cb5c65e into kiegroup:master Apr 3, 2020
@vpellegrino vpellegrino deleted the DROOLS-3843 branch April 6, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants