Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AF-2462: Minor fixes on the project sample card #3259

Merged
merged 2 commits into from Apr 9, 2020
Merged

AF-2462: Minor fixes on the project sample card #3259

merged 2 commits into from Apr 9, 2020

Conversation

caponetto
Copy link
Member

Task: AF-2462

Fixes:

  • Card title height (letters like 'g' and 'p' were being cut)
  • Card description width (the text was being truncated before needed)

Result:
Screenshot from 2020-04-06 14-30-15

@caponetto caponetto requested a review from paulovmr April 6, 2020 18:05
@paulovmr
Copy link
Member

paulovmr commented Apr 6, 2020

jenkins retest this

jenkins execute full downstream build

@caponetto
Copy link
Member Author

jenkins execute full downstream build

@caponetto caponetto requested a review from barboras7 April 7, 2020 20:40
@barboras7
Copy link
Contributor

Hi @caponetto,

could you please apply the same fix also to the project list? When I choose some sample project and then I open the space (where I put the project), the description is truncated as it used to be in the Try Samples view (see my screenshot).
Screenshot from 2020-04-08 14-14-34

@caponetto
Copy link
Member Author

jenkins execute full downstream build

@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

barboras7
barboras7 approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@barboras7 barboras7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @caponetto!

@caponetto
Copy link
Member Author

Thanks, @barboras7 :)

@paulovmr feel free to merge it

@paulovmr paulovmr merged commit f2a7640 into kiegroup:master Apr 9, 2020
@caponetto caponetto deleted the AF-2462-master branch April 9, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulovmr paulovmr paulovmr approved these changes

@barboras7 barboras7 barboras7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@caponetto @paulovmr @barboras7