KOGITO-2674: [DMN Designer] Multiple DRDs support - Context menu component

[vpellegrino]

Please refer to: https://issues.redhat.com/browse/KOGITO-2674

Task description: Need a context menu for DRD actions

Proposed solution: Providing a generic context menu widget

There you can find an utilization example of this widget.
The result is the follow:

[karreiro]

Thank you, @vpellegrino, great stuff!

I personally, would add an extra show method like this (to avoid the API users from remembering that they need to reset the menu before showing it):

dRDContextMenu.show(self -> {
  self.setHeaderMenu("DRD ACTIONS", "fa fa-share-alt");
  self.addTextMenuItem("Create", true, () -> DomGlobal.console.log("A"));
  self.addTextMenuItem("Add to", true, () -> DomGlobal.console.log("B"));
  self.addTextMenuItem("Remove", true, () -> DomGlobal.console.log("C"));
});

Let me know wdyt :-)

[karreiro]

Ohh.. I've noticed another minor thing ;-)

[vpellegrino]

@karreiro I updated PR including your suggestions. Thanks for the feedback!

[karreiro]

Thanks, @vpellegrino ;-)

[vpellegrino]

Jenkins please retest this

[vpellegrino]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
1 Code Smell

83.1% Coverage
0.0% Duplication

The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

For the code smell, the Span element was already present in the constructor. I have only added a further parameter: the Icon. TBH, I would not change it, in order to be sure to not introduce regressions.

[karreiro]

Jenkins please retest this.

[vpellegrino]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
1 Code Smell

91.5% Coverage
0.0% Duplication

The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

The reason quality gate is failing:
0.0% Condition Coverage on New Code (is less than 80%)

Please let me know if there is any action pending from my side: coverage is now 91.5%

[jomarko]

@vpellegrino I haven't checked the code yet and kogito-channels.

I checked on business central using a DecisionNavigatorView you shared. It works pretty well on chrome. However I got and NullPointer and freezing screen on firefox [1].

I am concerned its caused because I touched code manually to have entry point for showing your new menu. I had idea if we can not use experimental API (documented here https://github.com/kiegroup/kie-docs/pull/1131/files) that displays feature implemented as experimental just if business central is started with -Dappformer.experimental.features=true. It would eliminate any mistake done by me when touching code locally. Not saying it is doable but at least worth to assume as I expect we will iterate over this feature longer time.

[1]

[vpellegrino]

@vpellegrino I haven't checked the code yet and kogito-channels.

I checked on business central using a DecisionNavigatorView you shared. It works pretty well on chrome. However I got and NullPointer and freezing screen on firefox [1].

I am concerned its caused because I touched code manually to have entry point for showing your new menu. I had idea if we can not use experimental API (documented here https://github.com/kiegroup/kie-docs/pull/1131/files) that displays feature implemented as experimental just if business central is started with -Dappformer.experimental.features=true. It would eliminate any mistake done by me when touching code locally. Not saying it is doable but at least worth to assume as I expect we will iterate over this feature longer time.

[1]

@jomarko thanks for your quick feedback.
It turns out that under firefox, event.path is not defined (https://www.thetopsites.net/article/53508096.shtml), so I have used composedPath() method instead. I tested it locally and works fine!

[vpellegrino]

Test failure org.kie.workbench.common.services.backend.compiler.ConcurrentBuildTest.buildFourProjectsInFourThread seems to be not related to this PR

[jomarko]

I manually retried firefox and VS code, seems working nice. Thank you @vpellegrino

[danielzhe]

Good job!

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
1 Code Smell

91.9% Coverage
0.0% Duplication

The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

[vpellegrino]

@kiegroup/gatekeepers can you please merge?