Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOGITO-2675: [DMN Designer] Multiple DRDs support - Context menu - Show the DRD clickable icon when node is selected #3362

Merged
merged 34 commits into from
Jul 28, 2020

Conversation

vpellegrino
Copy link
Contributor

Please refer to: https://issues.redhat.com/browse/KOGITO-2675

Task description: An icon with DRD actions should be shown when selecting single node

Proposed solution: using an instance of context menu widget

The result is the follow:
Peek-2020-07-17-16-44

@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

84.0% 84.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Copy link

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tried on

  • VS code
  • Online editor (Firefox, Chrome)

@vpellegrino nice clean code, thank you.

Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vpellegrino :-) LGTM, and works fine as well :-)

@karreiro karreiro merged commit 230b664 into kiegroup:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants