JBPM-9276 - Stunner Empty ErrorRef for the Error Start Event produces build errors

[hasys]

Hi @romartin,

I tested Kogito and XML looks good, will build Business Central locally to perform some End to End tests and will move it to full review. For now code is ready for the review.

Hi @domhanak, @LuboTerifaj, do we need your review here or we can assign it to two Software Engineers?

Thank you!

Business Central

https://drive.google.com/file/d/1OUikD9cxc008URF85eLjrfggPVueKLTK/view?usp=sharing

VS Code extension

https://drive.google.com/file/d/1ZvjXoy2St0A_J1gSXiQsxsgVmVFqUfVo/view?usp=sharing

Repository for tests

https://github.com/bpmn-tutorials/EmptyErrorTest

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

100.0% Coverage
5.3% Duplication

The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

[hasys]

Jenkins execute compile downstream build

[romartin]

@hasys code looks good to me! Thanks agian for this work 👍

[hasys]

Hi @romartin, @LuboTerifaj, @domhanak,

I noticed some differences between XMLs generated by Legacy and New designers:

• Legacy designer using only one shared Error xml node for all Events with empty error reference.
• Stunner generates individual Error xml nodes for each Event with empty error reference.

I didn't found any differences at runtime though. I used this (also mentioned in PR description) repo to test several Error Events at runtime and both processes (generated in Legacy and in Stunner) produced the same result:

Console log for the process created in the Legacy designer

12:03:13,647 WARN  [org.kie.server.services.jbpm.ui.FormServiceBase] (default task-19) Unable to find form to render for process 'LegacyNoNameErrorHandling'
12:03:14,571 INFO  [stdout] (default task-19) Script2: error handling
12:03:14,632 INFO  [stdout] (default task-19) Script3: error handling

Console log for the process created in the Stunner

12:03:19,280 WARN  [org.kie.server.services.jbpm.ui.FormServiceBase] (default task-19) Unable to find form to render for process 'StunnerNoNameErrorHandling'
12:03:20,254 INFO  [stdout] (default task-19) Script3: error handling
12:03:20,264 INFO  [stdout] (default task-19) Script2: error handling

Since I can't see any difference at runtime and I didn't found any information in BPMN 2.0 specification how empty error reference should be addressed I think there is no need to fix it in this PR.

Thank you! This PR is ready for the review.

[domhanak]

LGTM.

Original use case is possible and user can have one event sub process with error start node to handle errors in process.
When there is a named error start event it will take precedence over the one with empty errorRef so that is working too.
Also, there a no build errors for me.
Thanks @hasys

[hasys]

@romartin this PR is ready for merge.

@romartin, @domhanak thank you!

[romartin]

thanks a lot for the great work guys!
@hasys @domhanak