New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DROOLS-5664 DMN editor reporting unsaved changes in DMN files after no changes #3467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from my side for this approach, @vpellegrino! As soon as we add an unit test, we can merge the fix :-)
jenkins do fdb |
Please check build results. |
jenkins do fdb |
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @vpellegrino!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
…o changes (kiegroup#3467) DROOLS-5664 DMN editor reporting unsaved changes in DMN files after no changes (kiegroup#3467)
JIRA: https://issues.redhat.com/browse/DROOLS-5664
How it works:
2.1. if they are different (the method super.mayClose(getCurrentDiagramHash()) returns false), the "unsaved changes" modal is displayed.
Provided solution:
Several operations may happen before the diagram is drawn (for example element wrapping, etc.), so it is recommended to compute and store che original diagram hash after the diagram gets loaded (inspired by kie-wb-common-stunner-kogito-client)
Recorded demo:
How to retest this PR or trigger a specific build: