Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHPAM-2781: Data Modeller "Search Annotation" requires FQN of annotation to be used #3521

Merged
merged 1 commit into from Dec 18, 2020
Merged

RHPAM-2781: Data Modeller "Search Annotation" requires FQN of annotation to be used #3521

merged 1 commit into from Dec 18, 2020

Conversation

akumar074
Copy link
Member

  • Changed the page title from "Search annotation" to "Load annotation"
  • Changed search field placeholder from "search annotation class name" to "load annotation class name"

JIRA: RHPAM-2781

How to retest this PR or trigger a specific build:
  • Retest PR: jenkins retest this
  • A full downstream build: jenkins do fdb
  • A compile downstream build: jenkins do cdb
  • A full production downstream build: jenkins do product fdb
  • An upstream build: jenkins do upstream

@akumar074
RHPAM-2781: Data Modeller "Search Annotation" requires FQN of annotat…
47b9f98 
…ion to be used

 - Changed the page title from "Search annotation" to "Load annotation"
 - Changed search field placeholder from "search annotation class name" to "load annotation class name"
@kie-ci
Copy link

kie-ci commented Dec 16, 2020

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@akumar074
Copy link
Member Author

jenkins do fdb

@kie-ci
Copy link

kie-ci commented Dec 16, 2020

Build finished. No test results found.

@akumar074
Copy link
Member Author

jenkins do fdb

@akumar074
Copy link
Member Author

jenkins retest this

1 similar comment
@akumar074
Copy link
Member Author

jenkins retest this

@akumar074
Copy link
Member Author

jenkins do fdb

@akumar074
Copy link
Member Author

Hi @paulovmr @dupliaka Please review the PR.

dupliaka
dupliaka approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@dupliaka dupliaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akumar074
Copy link
Member Author

jenkins retest this

@akumar074
Copy link
Member Author

jenkins do fdb

@sonarcloud
Copy link

sonarcloud bot commented Dec 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@paulovmr paulovmr merged commit ac37d64 into kiegroup:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulovmr paulovmr paulovmr approved these changes

@dupliaka dupliaka dupliaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@akumar074 @kie-ci @paulovmr @dupliaka