Remove Kogito profile to productize required components #3541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alberto Morales Pérez <almorale@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Ginxo
approved these changes
Jan 15, 2021
| <id>kogito</id> | ||
| <activation> | ||
| <property> | ||
| <name>!productized</name> |
There was a problem hiding this comment.
@almope
Why don't we use kogitoProductized instead?
There was a problem hiding this comment.
we need to build it in community default workflow too @Ginxo ;)
There was a problem hiding this comment.
@Ginxo adding a new property implies that for both community and product build we have to add that as a parameter. Previously the productized property avoids the plugin executions on productization builds while now we need in all kind of builds.
AntStephenson
approved these changes
Jan 15, 2021
almope
changed the title
mareknovotny
approved these changes
Jan 15, 2021
vpellegrino
pushed a commit
to vpellegrino/kie-wb-common
that referenced
this pull request
Jan 18, 2021
Signed-off-by: Alberto Morales Pérez <almorale@redhat.com>
vpellegrino
pushed a commit
to vpellegrino/kie-wb-common
that referenced
this pull request
Jan 18, 2021
Signed-off-by: Alberto Morales Pérez <almorale@redhat.com>
bxf12315
pushed a commit
to Cory-jbpm/kie-wb-common
that referenced
this pull request
Feb 2, 2021
Signed-off-by: Alberto Morales Pérez <almorale@redhat.com>
almope
pushed a commit
to almope/kie-wb-common
that referenced
this pull request
Feb 4, 2021
Signed-off-by: Alberto Morales Pérez <almorale@redhat.com>
mareknovotny
pushed a commit
that referenced
this pull request
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alberto Morales Pérez almorale@redhat.com
Thank you for submitting this pull request
JIRA: (https://issues.redhat.com/browse/RHPAM-3393)
Referenced Pull Requests:
Business Central: n/a
VS Code: n/a
How to retest this PR or trigger a specific build: