Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF-2795: use managed jackson-databind version #3554

Merged
merged 1 commit into from Feb 3, 2021

Conversation

jomarko
Copy link

@jomarko jomarko commented Feb 2, 2021

Use 'version.com.fasterxml.jackson.databind' from https://github.com/kiegroup/droolsjbpm-build-bootstrap/blob/master/pom.xml to fix issue reproted by dependabot

For more details see: https://issues.redhat.com/browse/AF-2795

Thank you for submitting this pull request

JIRA: JBPM-0000

Referenced Pull Requests:

  • paste the link(s) from GitHub here
  • link 2
  • link 3 etc.

Business Central: WAR file

VS Code: plugin

How to retest this PR or trigger a specific build:
  • Retest PR: jenkins retest this
  • A full downstream build: jenkins do fdb
  • A compile downstream build: jenkins do cdb
  • A full production downstream build: jenkins do product fdb
  • An upstream build: jenkins do upstream

Use 'version.com.fasterxml.jackson.databind' from https://github.com/kiegroup/droolsjbpm-build-bootstrap/blob/master/pom.xml to fix issue reproted by dependabot

For more details see: https://issues.redhat.com/browse/AF-2795
@jomarko
Copy link
Author

jomarko commented Feb 2, 2021

Jenkins do fdb

@caponetto
Copy link
Member

Hi @jomarko. I'm curious, do these changes work?
I mean, these pom files do not inherit from kie-parent so I'm thinking if they could really reuse version.com.fasterxml.jackson.databind.

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jomarko
Copy link
Author

jomarko commented Feb 2, 2021

@caponetto as checks passed, I hope yes.

@mareknovotny
Copy link
Member

kie-parent properties are available in the build itself /so all tests or other invoked process will have them accesible/. If you run the test projects as standalone project, properties in kie-parent won't be available.

@mareknovotny mareknovotny merged commit 57510a3 into kiegroup:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants