Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF-2799 Update kie-wb-common unit tests deprecated classes #3560

Merged
merged 4 commits into from Feb 11, 2021

Conversation

jomarko
Copy link

@jomarko jomarko commented Feb 8, 2021

Thank you for submitting this pull request

Jira: AF-2799

How to retest this PR or trigger a specific build:
  • Retest PR: jenkins retest this
  • A full downstream build: jenkins do fdb
  • A compile downstream build: jenkins do cdb
  • A full production downstream build: jenkins do product fdb
  • An upstream build: jenkins do upstream

@jomarko
Copy link
Author

jomarko commented Feb 8, 2021

Jenkins please retest this

@jomarko
Copy link
Author

jomarko commented Feb 9, 2021

There is a compilation error on master

22:17:51  [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project optaplanner-core: Compilation failure: Compilation failure: 
22:17:51  [ERROR] /home/jenkins/workspace/KIE/master/pullrequest/kie-wb-common-master.pr/kiegroup_optaplanner/optaplanner-core/src/main/java/org/optaplanner/core/impl/score/stream/drools/uni/DroolsUniCondition.java:[226,26] wrong number of type arguments; required 2
22:17:51  [ERROR] /home/jenkins/workspace/KIE/master/pullrequest/kie-wb-common-master.pr/kiegroup_optaplanner/optaplanner-core/src/main/java/org/optaplanner/core/impl/score/stream/drools/uni/DroolsUniCondition.java:[310,22] wrong number of type arguments; required 2
22:17:51  [ERROR] -> [Help 1]
22:17:51  org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project optaplanner-core: Compilation failure

@jomarko
Copy link
Author

jomarko commented Feb 9, 2021

Jenkins please retest this

@jomarko jomarko force-pushed the AF-2799 branch 2 times, most recently from 0487d8f to af1c1f3 Compare February 9, 2021 15:09
@jomarko jomarko marked this pull request as ready for review February 9, 2021 19:51
@jomarko
Copy link
Author

jomarko commented Feb 10, 2021

Jenkins please retest this

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ederign
Copy link
Member

ederign commented Feb 10, 2021

@caponetto can you please review this?

Copy link
Member

@caponetto caponetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jomarko for this effort! It looks great to me.

@Srihari1192 Srihari1192 self-requested a review February 11, 2021 07:53
Copy link

@Srihari1192 Srihari1192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jomarko
Copy link
Author

jomarko commented Feb 11, 2021

@kiegroup/gatekeepers please merge

@danielezonca danielezonca merged commit dca5949 into kiegroup:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants