Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOGITO-4233: [DMN Designer] IntelliSense service #3590

Merged
merged 7 commits into from Mar 26, 2021
Merged

KOGITO-4233: [DMN Designer] IntelliSense service #3590

merged 7 commits into from Mar 26, 2021

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Mar 10, 2021 •
edited

JIRA: KOGITO-4233: [DMN Designer] IntelliSense service

2021-03-10 21 06 43

Part of an ensemble:

Artifacts:

How to retest this PR or trigger a specific build:

  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

This was referenced Mar 10, 2021
Merged
Merged
Merged
Merged
Merged
@karreiro
Copy link
Contributor Author

Jenkins please retest this.

1 similar comment
@Rikkola
Copy link
Member

Rikkola commented Mar 11, 2021

Jenkins please retest this.

@karreiro
Copy link
Contributor Author

Jenkins please retest this.

Rikkola
Rikkola approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@Rikkola Rikkola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@karreiro
Copy link
Contributor Author

Jenkins please retest this.

@karreiro
Copy link
Contributor Author

Jenkins please retest this.

@karreiro karreiro force-pushed the KOGITO-4233 branch 2 times, most recently from 45a30c4 to 18d0b57 Compare March 18, 2021 17:59
danielzhe
danielzhe approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@danielzhe danielzhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I started "playing" with this new IntelliSense and loved! Very good. I think our user will be very happy.

jomarko
jomarko reviewed Mar 24, 2021
View reviewed changes
Copy link

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with code review, I will proceed to manual, however more proper description of what is supported and what is not is needed from my point of view.

If I read code, I understand we can not parse DATE expression ad eliminate suggestions accordingly. however if we do nto capture it to some acceptance criteria, we do not have a reference point for future tickets from customers.

This is not ready for merge.

...n/java/org/kie/workbench/common/dmn/client/widgets/codecompletion/MonacoFEELInitializer.java Show resolved Hide resolved
...n/java/org/kie/workbench/common/dmn/client/widgets/codecompletion/MonacoFEELSuggestions.java Outdated Show resolved Hide resolved
...n/java/org/kie/workbench/common/dmn/client/widgets/codecompletion/MonacoFEELSuggestions.java Show resolved Hide resolved
...kie/workbench/common/dmn/client/widgets/codecompletion/MonacoSuggestionsPropertyFactory.java Show resolved Hide resolved
...kie/workbench/common/dmn/client/widgets/codecompletion/MonacoSuggestionsPropertyFactory.java Show resolved Hide resolved
.../src/main/java/org/kie/workbench/common/dmn/client/widgets/codecompletion/feel/Variable.java Show resolved Hide resolved
...va/org/kie/workbench/common/dmn/client/widgets/codecompletion/MonacoFEELSuggestionsTest.java Show resolved Hide resolved
...esting/src/main/java/org/kie/workbench/common/dmn/showcase/client/feel/DefaultedVisitor.java Outdated Show resolved Hide resolved
...org/kie/workbench/common/dmn/client/widgets/codecompletion/feel/FEELLanguageServiceTest.java Outdated Show resolved Hide resolved
...org/kie/workbench/common/dmn/client/widgets/codecompletion/feel/FEELLanguageServiceTest.java Show resolved Hide resolved
@jomarko
Copy link

jomarko commented Mar 25, 2021

Manual Review 01

Different suggestions for negated boolean expresisons https://issues.redhat.com/browse/DROOLS-6207

@jomarko
Copy link

jomarko commented Mar 25, 2021

Manual review 02

Date expressions offers functions returning string https://issues.redhat.com/browse/DROOLS-6208

@jomarko
Copy link

jomarko commented Mar 25, 2021

Manual review 03

Similar as 02, duration expressions are assumed as string expressions https://issues.redhat.com/browse/DROOLS-6209

@jomarko
Copy link

jomarko commented Mar 25, 2021

Manual review 04

Suggestions do not recognize variables https://issues.redhat.com/browse/DROOLS-6210

@jomarko
Copy link

jomarko commented Mar 25, 2021

Manual review 05

Addition of two sum functions is a list instead of number https://issues.redhat.com/browse/DROOLS-6211

@jomarko
Copy link

jomarko commented Mar 25, 2021

Manual review 06

Suggestions for function arguments https://issues.redhat.com/browse/DROOLS-6214

@jomarko
Copy link

jomarko commented Mar 25, 2021

Review finished

Reported issues linked in comments above. No need to fix them as part of this PR. I crated also reproducers tests for them, see
karreiro#12

One more update pending for kie-wb-common-dmn-webapp-kogito-runtime to verify autocompletion editor is shown.

@karreiro thank you for this work.

@karreiro
- Remove 'DefaultedVisitor' class
4a8bd4e 
 - Update the date in copyright headers
 - Additional coverage
@karreiro
Copy link
Contributor Author

Thank you, @jomarko.

All changes applied (including the linked PR).

Also, I've rebuilt artifacts, and they are available in the PR description.

Thanks again.

jomarko
jomarko approved these changes Mar 25, 2021
View reviewed changes
Copy link

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updates.

Last recheck of internal tests with war v2 passed.

Lets merge once builds are green.

@karreiro
Copy link
Contributor Author

Jenkins run fdb.

@sonarcloud
Copy link

sonarcloud bot commented Mar 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 39 Code Smells

77.7% 77.7% Coverage
0.0% 0.0% Duplication

@karreiro
Copy link
Contributor Author

Jenkins run fdb.

1 similar comment
@karreiro
Copy link
Contributor Author

Jenkins run fdb.

@ederign ederign merged commit 06e5732 into kiegroup:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rikkola Rikkola Rikkola approved these changes

@danielzhe danielzhe danielzhe approved these changes

@jomarko jomarko jomarko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@karreiro @Rikkola @jomarko @danielzhe @ederign