Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUVNOR-3237: Change the home page to the new one #993

Merged
merged 1 commit into from
Jul 28, 2017
Merged

GUVNOR-3237: Change the home page to the new one #993

merged 1 commit into from
Jul 28, 2017

Conversation

paulovmr
Copy link
Member

No description provided.

@paulovmr
Copy link
Member Author

paulovmr commented Jul 26, 2017 •
edited

Part of an ensemble:

This was referenced Jul 26, 2017
Merged
Merged
Merged
Merged
@jhrcek
Copy link

jhrcek commented Jul 26, 2017 •
edited

@paulovmr Looks like the build failure is related to @porcelli 's PR merged yesterday in uberfire. Can you please update this PR based on that and rerun the build and if it passes also run full downstream build? I'm eager to see the the new home page in action :-)

manstis
manstis reviewed Jul 26, 2017
View reviewed changes
Copy link
Member

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @paulovmr - just one date to update really :-)

...-common-home-api/src/main/java/org/kie/workbench/common/screens/home/model/HomeShortcut.java Outdated
@@ -0,0 +1,87 @@
/*
* Copyright 2015 Red Hat, Inc. and/or its affiliates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2017

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

...client/src/main/java/org/kie/workbench/common/screens/home/client/widgets/home/HomeView.html Outdated

<div class="home">
<div class="kie-page">
<div data-field="container" class="kie-page__content kie-content--bg-image kie-blank-slate">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting inconsistent format of class names.. just a comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently they follow this methodology :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I live and learn :-)

@tomasdavidorg
Copy link
Contributor

Jenkins execute full downstream build

1 similar comment
@porcelli
Copy link
Member

Jenkins execute full downstream build

@paulovmr paulovmr mentioned this pull request Jul 27, 2017
Merged
@paulovmr
Copy link
Member Author

jenkins retest this

@manstis manstis merged commit 6f325c3 into kiegroup:master Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manstis manstis manstis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@paulovmr @jhrcek @tomasdavidorg @porcelli @manstis