Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF-2948: Update Firefox Gecko driver to version 0.33.0 #1215

Merged
merged 1 commit into from Apr 13, 2023

Conversation

tomasdavidorg
Copy link
Contributor

@tomasdavidorg tomasdavidorg commented Apr 11, 2023

Thank you for submitting this pull request

JIRA: AF-2948

referenced Pull Requests:

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@tomasdavidorg tomasdavidorg added the DO NOT MERGE Don't merge this or else! label Apr 11, 2023
@tomasdavidorg
Copy link
Contributor Author

@Ginxo @barboras7 This PR updates Firefox Gecko driver after Firefox update in kiegroup/droolsjbpm-build-bootstrap#2253. I am still testing if the latest version works with the updated Firefox 91esr. If there is some issue, I will downgrade the driver to the compatible version according to the compatibility table .

@tomasdavidorg
Copy link
Contributor Author

jenkins retest this please

@tomasdavidorg tomasdavidorg added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch and removed DO NOT MERGE Don't merge this or else! labels Apr 11, 2023
@tomasdavidorg tomasdavidorg removed backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Apr 11, 2023
Copy link
Contributor

@Ginxo Ginxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ginxo
Copy link
Contributor

Ginxo commented Apr 13, 2023

@tomasdavidorg ready to merge?

@tomasdavidorg
Copy link
Contributor Author

@Ginxo Yes. Thanks.

@Ginxo Ginxo merged commit 45a1837 into kiegroup:main Apr 13, 2023
7 of 9 checks passed
@tomasdavidorg tomasdavidorg deleted the AF-2948 branch April 13, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants