This repository has been archived by the owner on Feb 12, 2020. It is now read-only.
KOGITO-772 - Upgrade Quarkus to version 1.1.0 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianonicolai
requested review from
mswiderski,
ricardozanini and
nmirasch
mswiderski
approved these changes
Dec 20, 2019
cristianonicolai
force-pushed
the
KOGITO-772
branch
from
d417689
to
976f6ce
Compare
| @@ -58,7 +58,7 @@ | |||
| <version.com.github.javaparser>3.13.10</version.com.github.javaparser> | |||
| <version.com.fasterxml.jackson>2.9.10</version.com.fasterxml.jackson> | |||
| <version.kubernetes-client>4.4.2</version.kubernetes-client> | |||
| <version.okhttp>3.12.0</version.okhttp> | |||
| <version.okhttp>3.12.6</version.okhttp> | |||
There was a problem hiding this comment.
@cristianonicolai we might need too revert back this one or upgrade the kubernetes-client version also:
https://github.com/fabric8io/kubernetes-client/blob/v4.4.2/pom.xml#L85
But this kubernetes-client must follow Quarkus one.
There was a problem hiding this comment.
@ricardozanini done :)
cristianonicolai
force-pushed
the
KOGITO-772
branch
2 times, most recently
from
1814b7f
to
67f5e86
Compare
ricardozanini
approved these changes
Jan 7, 2020
radtriste
reviewed
Jan 7, 2020
pom.xml
Outdated
| @@ -57,8 +57,8 @@ | |||
| <version.org.eclipse.jdt>3.19.0</version.org.eclipse.jdt> | |||
| <version.com.github.javaparser>3.13.10</version.com.github.javaparser> | |||
| <version.com.fasterxml.jackson>2.9.10</version.com.fasterxml.jackson> | |||
| <version.kubernetes-client>4.4.2</version.kubernetes-client> | |||
| <version.okhttp>3.12.0</version.okhttp> | |||
| <version.kubernetes-client>4.6.4</version.kubernetes-client> | |||
There was a problem hiding this comment.
updating kubernetes-client to 4.6.4 requires an update of jackson
see #76
We should put version 4.6.2
There was a problem hiding this comment.
@radtriste ack, thanks.
nmirasch
approved these changes
Jan 10, 2020
cristianonicolai
force-pushed
the
KOGITO-772
branch
from
67f5e86
to
74a1a1f
Compare
cristianonicolai
force-pushed
the
KOGITO-772
branch
from
74a1a1f
to
f45b838
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assembly: