Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

[KOGITO-248] - Rebranding APP commands for CLI to PROJECT terminology #52

Merged
merged 1 commit into from Sep 10, 2019
Merged

[KOGITO-248] - Rebranding APP commands for CLI to PROJECT terminology #52

merged 1 commit into from Sep 10, 2019

Conversation

ricardozanini
Copy link
Member

@ricardozanini ricardozanini commented Sep 9, 2019 •
edited

See:
https://issues.jboss.org/browse/KOGITO-248

In this PR:

  1. Rebranding app and new-app to use-project and new-project
  2. Added version command
  3. Renaming deploy to deploy-service

TODO:

1. Refactor deploy, depends on #50

Many thanks for submiting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a unit test that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster

@ricardozanini ricardozanini added on hold ✋ Pull Request is waiting for other dependencies WIP 👷‍♂️ Pull Request is on work in progress labels Sep 9, 2019
@ricardozanini ricardozanini mentioned this pull request Sep 10, 2019
Merged
7 tasks
@ricardozanini ricardozanini added needs review 🔍 Pull Request that needs reviewers and removed WIP 👷‍♂️ Pull Request is on work in progress on hold ✋ Pull Request is waiting for other dependencies labels Sep 10, 2019
@ricardozanini ricardozanini force-pushed the kogito-248 branch 2 times, most recently from 24de14c to 8ffb23c Compare September 10, 2019 17:30
xieshenzh
xieshenzh approved these changes Sep 10, 2019
View reviewed changes
cmd/kogito/deploy.go Show resolved Hide resolved
@ricardozanini ricardozanini added ready 🚀 PR is ready to be merged and removed needs review 🔍 Pull Request that needs reviewers labels Sep 10, 2019
@ricardozanini ricardozanini merged commit dc36e58 into apache:master Sep 10, 2019
@ricardozanini ricardozanini deleted the kogito-248 branch September 10, 2019 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xieshenzh xieshenzh xieshenzh approved these changes

Assignees
No one assigned
Labels
ready 🚀 PR is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ricardozanini @xieshenzh