Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

kie-parent version bump for 7.58.0.Final #93

Merged
merged 4 commits into from
Aug 20, 2021
Merged

kie-parent version bump for 7.58.0.Final #93

merged 4 commits into from
Aug 20, 2021

Conversation

ederign
Copy link
Member

@ederign ederign commented Aug 10, 2021

No description provided.

@ederign ederign requested a review from karreiro August 10, 2021 20:49
@karreiro karreiro requested a review from romartin August 11, 2021 09:35
karreiro
karreiro approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ederign!

@ederign ederign requested a review from yesamer August 11, 2021 13:00
@yesamer
Copy link
Member

yesamer commented Aug 13, 2021

@ederign please wait until Tuesday, as I said I introduced some changes in the scesim api and I need to check it.

yesamer
yesamer approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ederign @karreiro Approved.
Please consider merging #97 after this, in order to keep synchronized API changes I introduced in drools repo.

yesamer
yesamer reviewed Aug 17, 2021
View reviewed changes
Copy link
Member

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we update the version on line 160 as well? @ederign

yesamer
yesamer suggested changes Aug 17, 2021
View reviewed changes
Copy link
Member

@yesamer yesamer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we update the version on line 160 as well? @ederign

@ederign
Copy link
Member Author

ederign commented Aug 17, 2021

@yesamer my bad! fixed! Thanks for spotting it

yesamer
yesamer approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ederign Great, thx u. I approve the change, but I see a failing test on scesim side, this should be solved here #97.

@karreiro
Copy link
Contributor

@tiagobento Could you please take a look at this PR? :)

@tiagobento
Copy link
Collaborator

Changes look good to me. Ok to merge when green. We might need to rebase this PR after #97 .

@karreiro karreiro merged commit 2d62e57 into kiegroup:main Aug 20, 2021
vpellegrino pushed a commit to vpellegrino/kogito-editors-java that referenced this pull request Aug 23, 2021
@ederign
kie-parent version bump for 7.58.0.Final (kiegroup#93)
c9a718d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karreiro karreiro karreiro approved these changes

@tiagobento tiagobento tiagobento approved these changes

@romartin romartin romartin approved these changes

@yesamer yesamer yesamer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@ederign @yesamer @karreiro @tiagobento @romartin