Skip to content

Commit

Permalink
feat: Migrate to undici MockClient
Browse files Browse the repository at this point in the history
Breaking change!

- Internally uses `undici`'s `MockAgent`, instead of `nock` to mock requests.
- `nock` is still used for data-matching to retain backwards
  compatibility.
- Tests now use `fetch` instead of `axios`.

Requires node>=18 and @octokit/rest>=20
  • Loading branch information
oliversalzburg committed Oct 27, 2023
1 parent f78df0b commit a196cef
Show file tree
Hide file tree
Showing 18 changed files with 5,141 additions and 4,265 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20
registry-url: https://registry.npmjs.org/

- name: Install packages
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
tests:
strategy:
matrix:
node-version: [16.x]
node-version: [20]
os: [ubuntu-latest]
fail-fast: false
runs-on: ${{ matrix.os }}
Expand All @@ -36,7 +36,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20

- name: Install packages
run: npm ci
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Setup sonarqube
uses: warchant/setup-sonar-scanner@v3
uses: warchant/setup-sonar-scanner@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20
- run: npm ci
- run: npm run test:report
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20
cache: npm
- run: npm install @octokit/openapi-types-ghec -D
- run: npm ci
Expand Down

0 comments on commit a196cef

Please sign in to comment.